Skip to content

Commit e200b4b

Browse files
committed
fix(WebAssembly): Correct NativeError subclass types
1 parent 7345e8d commit e200b4b

File tree

4 files changed

+120
-15
lines changed

4 files changed

+120
-15
lines changed

baselines/dom.generated.d.ts

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19043,12 +19043,15 @@ declare namespace CSS {
1904319043
}
1904419044

1904519045
declare namespace WebAssembly {
19046-
interface CompileError {
19046+
interface CompileError extends Error {
19047+
message: string;
19048+
name: string;
1904719049
}
1904819050

1904919051
var CompileError: {
1905019052
prototype: CompileError;
19051-
new(): CompileError;
19053+
new(message?: string): CompileError;
19054+
(message?: string): CompileError;
1905219055
};
1905319056

1905419057
interface Global {
@@ -19070,12 +19073,15 @@ declare namespace WebAssembly {
1907019073
new(module: Module, importObject?: Imports): Instance;
1907119074
};
1907219075

19073-
interface LinkError {
19076+
interface LinkError extends Error {
19077+
message: string;
19078+
name: string;
1907419079
}
1907519080

1907619081
var LinkError: {
1907719082
prototype: LinkError;
19078-
new(): LinkError;
19083+
new(message?: string): LinkError;
19084+
(message?: string): LinkError;
1907919085
};
1908019086

1908119087
interface Memory {
@@ -19099,12 +19105,15 @@ declare namespace WebAssembly {
1909919105
imports(moduleObject: Module): ModuleImportDescriptor[];
1910019106
};
1910119107

19102-
interface RuntimeError {
19108+
interface RuntimeError extends Error {
19109+
message: string;
19110+
name: string;
1910319111
}
1910419112

1910519113
var RuntimeError: {
1910619114
prototype: RuntimeError;
19107-
new(): RuntimeError;
19115+
new(message?: string): RuntimeError;
19116+
(message?: string): RuntimeError;
1910819117
};
1910919118

1911019119
interface Table {

baselines/webworker.generated.d.ts

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5713,6 +5713,17 @@ interface Console {
57135713
declare var console: Console;
57145714

57155715
declare namespace WebAssembly {
5716+
interface CompileError extends Error {
5717+
message: string;
5718+
name: string;
5719+
}
5720+
5721+
var CompileError: {
5722+
prototype: CompileError;
5723+
new(message?: string): CompileError;
5724+
(message?: string): CompileError;
5725+
};
5726+
57165727
interface Global {
57175728
value: any;
57185729
valueOf(): any;
@@ -5732,6 +5743,17 @@ declare namespace WebAssembly {
57325743
new(module: Module, importObject?: Imports): Instance;
57335744
};
57345745

5746+
interface LinkError extends Error {
5747+
message: string;
5748+
name: string;
5749+
}
5750+
5751+
var LinkError: {
5752+
prototype: LinkError;
5753+
new(message?: string): LinkError;
5754+
(message?: string): LinkError;
5755+
};
5756+
57355757
interface Memory {
57365758
readonly buffer: ArrayBuffer;
57375759
grow(delta: number): number;
@@ -5753,6 +5775,17 @@ declare namespace WebAssembly {
57535775
imports(moduleObject: Module): ModuleImportDescriptor[];
57545776
};
57555777

5778+
interface RuntimeError extends Error {
5779+
message: string;
5780+
name: string;
5781+
}
5782+
5783+
var RuntimeError: {
5784+
prototype: RuntimeError;
5785+
new(message?: string): RuntimeError;
5786+
(message?: string): RuntimeError;
5787+
};
5788+
57565789
interface Table {
57575790
readonly length: number;
57585791
get(index: number): Function | null;

inputfiles/addedTypes.json

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2274,6 +2274,78 @@
22742274
}
22752275
]
22762276
}
2277+
},
2278+
"CompileError": {
2279+
"name": "CompileError",
2280+
"legacy-namespace": "WebAssembly",
2281+
"extends": "Error",
2282+
"exposed": "Window Worker Worklet",
2283+
"constructor": {
2284+
"override-signatures": [
2285+
"new(message?: string): CompileError",
2286+
"(message?: string): CompileError"
2287+
]
2288+
},
2289+
"properties": {
2290+
"property": {
2291+
"name": {
2292+
"name": "name",
2293+
"type": "DOMString"
2294+
},
2295+
"message": {
2296+
"name": "message",
2297+
"type": "DOMString"
2298+
}
2299+
}
2300+
}
2301+
},
2302+
"LinkError":{
2303+
"name": "LinkError",
2304+
"legacy-namespace": "WebAssembly",
2305+
"extends": "Error",
2306+
"exposed": "Window Worker Worklet",
2307+
"constructor": {
2308+
"override-signatures": [
2309+
"new(message?: string): LinkError",
2310+
"(message?: string): LinkError"
2311+
]
2312+
},
2313+
"properties": {
2314+
"property": {
2315+
"name": {
2316+
"name": "name",
2317+
"type": "DOMString"
2318+
},
2319+
"message": {
2320+
"name": "message",
2321+
"type": "DOMString"
2322+
}
2323+
}
2324+
}
2325+
},
2326+
"RuntimeError":{
2327+
"name": "RuntimeError",
2328+
"legacy-namespace": "WebAssembly",
2329+
"extends": "Error",
2330+
"exposed": "Window Worker Worklet",
2331+
"constructor": {
2332+
"override-signatures": [
2333+
"new(message?: string): RuntimeError",
2334+
"(message?: string): RuntimeError"
2335+
]
2336+
},
2337+
"properties": {
2338+
"property": {
2339+
"name": {
2340+
"name": "name",
2341+
"type": "DOMString"
2342+
},
2343+
"message": {
2344+
"name": "message",
2345+
"type": "DOMString"
2346+
}
2347+
}
2348+
}
22772349
}
22782350
}
22792351
},

inputfiles/idl/WebAssembly JavaScript Interface.widl

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -94,12 +94,3 @@ interface Global {
9494
any valueOf();
9595
attribute any value;
9696
};
97-
98-
[LegacyNamespace=WebAssembly]
99-
interface CompileError { };
100-
101-
[LegacyNamespace=WebAssembly]
102-
interface LinkError { };
103-
104-
[LegacyNamespace=WebAssembly]
105-
interface RuntimeError { };

0 commit comments

Comments
 (0)