Skip to content

Commit d3bf34f

Browse files
committed
further code cleanup
1 parent 58af0a4 commit d3bf34f

File tree

3 files changed

+5
-14
lines changed

3 files changed

+5
-14
lines changed

src/emitter.ts

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,8 @@ function createTextWriter(newLine: string) {
5959
/** print declarations conflicting with base interface to a side list to write them under a diffrent name later */
6060
let stack: { content: string, indent: number }[] = [];
6161

62-
const indentStrings: string[] = ["", " "];
6362
function getIndentString(level: number) {
64-
if (indentStrings[level] === undefined) {
65-
indentStrings[level] = getIndentString(level - 1) + indentStrings[1];
66-
}
67-
return indentStrings[level];
63+
return " ".repeat(level);
6864
}
6965

7066
function write(s: string) {
@@ -90,13 +86,12 @@ function createTextWriter(newLine: string) {
9086
reset();
9187

9288
return {
93-
reset: reset,
89+
reset,
9490

95-
resetIndent() { indent = 0; },
9691
increaseIndent() { indent++; },
9792
decreaseIndent() { indent--; },
9893

99-
endLine: endLine,
94+
endLine,
10095
print: write,
10196
printLine(c: string) { write(c); endLine(); },
10297

@@ -830,7 +825,7 @@ export function emitWebIdl(webidl: Browser.WebIdl, flavor: Flavor) {
830825
.filter(i => i !== "Object")
831826
.map(processIName));
832827

833-
if (finalExtends && finalExtends.length) {
828+
if (finalExtends.length) {
834829
printer.print(` extends ${finalExtends.join(", ")}`);
835830
}
836831
printer.print(" {");
@@ -916,7 +911,6 @@ export function emitWebIdl(webidl: Browser.WebIdl, flavor: Flavor) {
916911
printer.clearStack();
917912
emitInterfaceEventMap(i);
918913

919-
printer.resetIndent();
920914
emitInterfaceDeclaration(i);
921915
printer.increaseIndent();
922916

@@ -950,7 +944,6 @@ export function emitWebIdl(webidl: Browser.WebIdl, flavor: Flavor) {
950944
// Because in the two cases the interface contains different things, it might be easier to
951945
// read to separate them into two functions.
952946
function emitStaticInterfaceWithNonStaticMembers() {
953-
printer.resetIndent();
954947
emitInterfaceDeclaration(i);
955948
printer.increaseIndent();
956949

@@ -971,7 +964,6 @@ export function emitWebIdl(webidl: Browser.WebIdl, flavor: Flavor) {
971964
}
972965

973966
function emitPureStaticInterface() {
974-
printer.resetIndent();
975967
emitInterfaceDeclaration(i);
976968
printer.increaseIndent();
977969

src/idlfetcher.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ function extractCSSDefinitions(dom: DocumentFragment) {
8080
properties.map(property => `\n [CEReactions] attribute [TreatNullAs=EmptyString] CSSOMString ${
8181
hyphenToCamelCase(property)
8282
};`).join("")
83-
}\n};`
83+
}\n};`;
8484
}
8585

8686
function hyphenToCamelCase(name: string) {

src/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ function emitDom() {
3939
const tsWebIteratorsOutput = path.join(outputFolder, "dom.iterable.generated.d.ts");
4040
const tsWorkerOutput = path.join(outputFolder, "webworker.generated.d.ts");
4141

42-
4342
const overriddenItems = require(path.join(inputFolder, "overridingTypes.json"));
4443
const addedItems = require(path.join(inputFolder, "addedTypes.json"));
4544
const comments = require(path.join(inputFolder, "comments.json"));

0 commit comments

Comments
 (0)