Merge pull request #544 from timocov/fix543

mhegazy · web-flow · commit d0a51cdeb35e · 2018-08-02T09:30:04.000-07:00
Changed returned type of Element.getElementsByClassName to HTMLCollectionOf&lt;Element&gt;
diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts
@@ -4707,7 +4707,7 @@ interface Element extends Node, ParentNode, NonDocumentTypeChildNode, ChildNode,
     getAttributeNodeNS(namespaceURI: string, localName: string): Attr | null;
     getBoundingClientRect(): ClientRect | DOMRect;
     getClientRects(): ClientRectList | DOMRectList;
-    getElementsByClassName(classNames: string): NodeListOf<Element>;
+    getElementsByClassName(classNames: string): HTMLCollectionOf<Element>;
     getElementsByTagName<K extends keyof HTMLElementTagNameMap>(qualifiedName: K): HTMLCollectionOf<HTMLElementTagNameMap[K]>;
     getElementsByTagName<K extends keyof SVGElementTagNameMap>(qualifiedName: K): HTMLCollectionOf<SVGElementTagNameMap[K]>;
     getElementsByTagName(qualifiedName: string): HTMLCollectionOf<Element>;
diff --git a/inputfiles/addedTypes.json b/inputfiles/addedTypes.json
@@ -610,7 +610,7 @@
                         "getElementsByClassName": {
                             "name": "getElementsByClassName",
                             "override-signatures": [
-                                "getElementsByClassName(classNames: string): NodeListOf<Element>"
+                                "getElementsByClassName(classNames: string): HTMLCollectionOf<Element>"
                             ]
                         },
                         "closest": {

Original file line number	Diff line number	Diff line change
`@@ -610,7 +610,7 @@`
`610`	`610`	`"getElementsByClassName": {`
`611`	`611`	`"name": "getElementsByClassName",`
`612`	`612`	`"override-signatures": [`
`613`		`- "getElementsByClassName(classNames: string): NodeListOf<Element>"`
	`613`	`+ "getElementsByClassName(classNames: string): HTMLCollectionOf<Element>"`
`614`	`614`	`]`
`615`	`615`	`},`
`616`	`616`	`"closest": {`