Skip to content

Commit d056787

Browse files
k-ylesaschanaz
andauthored
better constant definitions for Websocket, EventSource, and FileReader (#1443)
Co-authored-by: saschanaz <[email protected]>
1 parent e6ccc40 commit d056787

File tree

5 files changed

+124
-80
lines changed

5 files changed

+124
-80
lines changed

baselines/dom.generated.d.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -5275,9 +5275,9 @@ interface EventSource extends EventTarget {
52755275
readonly withCredentials: boolean;
52765276
/** Aborts any instances of the fetch algorithm started for this EventSource object, and sets the readyState attribute to CLOSED. */
52775277
close(): void;
5278-
readonly CLOSED: number;
5279-
readonly CONNECTING: number;
5280-
readonly OPEN: number;
5278+
readonly CLOSED: 2;
5279+
readonly CONNECTING: 0;
5280+
readonly OPEN: 1;
52815281
addEventListener<K extends keyof EventSourceEventMap>(type: K, listener: (this: EventSource, ev: EventSourceEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
52825282
addEventListener(type: string, listener: (this: EventSource, event: MessageEvent) => any, options?: boolean | AddEventListenerOptions): void;
52835283
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
@@ -5289,9 +5289,9 @@ interface EventSource extends EventTarget {
52895289
declare var EventSource: {
52905290
prototype: EventSource;
52915291
new(url: string | URL, eventSourceInitDict?: EventSourceInit): EventSource;
5292-
readonly CLOSED: number;
5293-
readonly CONNECTING: number;
5294-
readonly OPEN: number;
5292+
readonly CLOSED: 2;
5293+
readonly CONNECTING: 0;
5294+
readonly OPEN: 1;
52955295
};
52965296

52975297
/** EventTarget is a DOM interface implemented by objects that can receive events and may have listeners for them. */
@@ -5386,9 +5386,9 @@ interface FileReader extends EventTarget {
53865386
readAsBinaryString(blob: Blob): void;
53875387
readAsDataURL(blob: Blob): void;
53885388
readAsText(blob: Blob, encoding?: string): void;
5389-
readonly DONE: number;
5390-
readonly EMPTY: number;
5391-
readonly LOADING: number;
5389+
readonly DONE: 2;
5390+
readonly EMPTY: 0;
5391+
readonly LOADING: 1;
53925392
addEventListener<K extends keyof FileReaderEventMap>(type: K, listener: (this: FileReader, ev: FileReaderEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
53935393
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
53945394
removeEventListener<K extends keyof FileReaderEventMap>(type: K, listener: (this: FileReader, ev: FileReaderEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -5398,9 +5398,9 @@ interface FileReader extends EventTarget {
53985398
declare var FileReader: {
53995399
prototype: FileReader;
54005400
new(): FileReader;
5401-
readonly DONE: number;
5402-
readonly EMPTY: number;
5403-
readonly LOADING: number;
5401+
readonly DONE: 2;
5402+
readonly EMPTY: 0;
5403+
readonly LOADING: 1;
54045404
};
54055405

54065406
interface FileSystem {
@@ -16857,10 +16857,10 @@ interface WebSocket extends EventTarget {
1685716857
close(code?: number, reason?: string): void;
1685816858
/** Transmits data using the WebSocket connection. data can be a string, a Blob, an ArrayBuffer, or an ArrayBufferView. */
1685916859
send(data: string | ArrayBufferLike | Blob | ArrayBufferView): void;
16860-
readonly CLOSED: number;
16861-
readonly CLOSING: number;
16862-
readonly CONNECTING: number;
16863-
readonly OPEN: number;
16860+
readonly CLOSED: 3;
16861+
readonly CLOSING: 2;
16862+
readonly CONNECTING: 0;
16863+
readonly OPEN: 1;
1686416864
addEventListener<K extends keyof WebSocketEventMap>(type: K, listener: (this: WebSocket, ev: WebSocketEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
1686516865
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
1686616866
removeEventListener<K extends keyof WebSocketEventMap>(type: K, listener: (this: WebSocket, ev: WebSocketEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -16870,10 +16870,10 @@ interface WebSocket extends EventTarget {
1687016870
declare var WebSocket: {
1687116871
prototype: WebSocket;
1687216872
new(url: string | URL, protocols?: string | string[]): WebSocket;
16873-
readonly CLOSED: number;
16874-
readonly CLOSING: number;
16875-
readonly CONNECTING: number;
16876-
readonly OPEN: number;
16873+
readonly CLOSED: 3;
16874+
readonly CLOSING: 2;
16875+
readonly CONNECTING: 0;
16876+
readonly OPEN: 1;
1687716877
};
1687816878

1687916879
/** Events that occur due to the user moving a mouse wheel or similar input device. */

baselines/serviceworker.generated.d.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1493,9 +1493,9 @@ interface EventSource extends EventTarget {
14931493
readonly withCredentials: boolean;
14941494
/** Aborts any instances of the fetch algorithm started for this EventSource object, and sets the readyState attribute to CLOSED. */
14951495
close(): void;
1496-
readonly CLOSED: number;
1497-
readonly CONNECTING: number;
1498-
readonly OPEN: number;
1496+
readonly CLOSED: 2;
1497+
readonly CONNECTING: 0;
1498+
readonly OPEN: 1;
14991499
addEventListener<K extends keyof EventSourceEventMap>(type: K, listener: (this: EventSource, ev: EventSourceEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
15001500
addEventListener(type: string, listener: (this: EventSource, event: MessageEvent) => any, options?: boolean | AddEventListenerOptions): void;
15011501
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
@@ -1507,9 +1507,9 @@ interface EventSource extends EventTarget {
15071507
declare var EventSource: {
15081508
prototype: EventSource;
15091509
new(url: string | URL, eventSourceInitDict?: EventSourceInit): EventSource;
1510-
readonly CLOSED: number;
1511-
readonly CONNECTING: number;
1512-
readonly OPEN: number;
1510+
readonly CLOSED: 2;
1511+
readonly CONNECTING: 0;
1512+
readonly OPEN: 1;
15131513
};
15141514

15151515
/** EventTarget is a DOM interface implemented by objects that can receive events and may have listeners for them. */
@@ -1629,9 +1629,9 @@ interface FileReader extends EventTarget {
16291629
readAsBinaryString(blob: Blob): void;
16301630
readAsDataURL(blob: Blob): void;
16311631
readAsText(blob: Blob, encoding?: string): void;
1632-
readonly DONE: number;
1633-
readonly EMPTY: number;
1634-
readonly LOADING: number;
1632+
readonly DONE: 2;
1633+
readonly EMPTY: 0;
1634+
readonly LOADING: 1;
16351635
addEventListener<K extends keyof FileReaderEventMap>(type: K, listener: (this: FileReader, ev: FileReaderEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
16361636
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
16371637
removeEventListener<K extends keyof FileReaderEventMap>(type: K, listener: (this: FileReader, ev: FileReaderEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -1641,9 +1641,9 @@ interface FileReader extends EventTarget {
16411641
declare var FileReader: {
16421642
prototype: FileReader;
16431643
new(): FileReader;
1644-
readonly DONE: number;
1645-
readonly EMPTY: number;
1646-
readonly LOADING: number;
1644+
readonly DONE: 2;
1645+
readonly EMPTY: 0;
1646+
readonly LOADING: 1;
16471647
};
16481648

16491649
/** Available only in secure contexts. */
@@ -5330,10 +5330,10 @@ interface WebSocket extends EventTarget {
53305330
close(code?: number, reason?: string): void;
53315331
/** Transmits data using the WebSocket connection. data can be a string, a Blob, an ArrayBuffer, or an ArrayBufferView. */
53325332
send(data: string | ArrayBufferLike | Blob | ArrayBufferView): void;
5333-
readonly CLOSED: number;
5334-
readonly CLOSING: number;
5335-
readonly CONNECTING: number;
5336-
readonly OPEN: number;
5333+
readonly CLOSED: 3;
5334+
readonly CLOSING: 2;
5335+
readonly CONNECTING: 0;
5336+
readonly OPEN: 1;
53375337
addEventListener<K extends keyof WebSocketEventMap>(type: K, listener: (this: WebSocket, ev: WebSocketEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
53385338
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
53395339
removeEventListener<K extends keyof WebSocketEventMap>(type: K, listener: (this: WebSocket, ev: WebSocketEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -5343,10 +5343,10 @@ interface WebSocket extends EventTarget {
53435343
declare var WebSocket: {
53445344
prototype: WebSocket;
53455345
new(url: string | URL, protocols?: string | string[]): WebSocket;
5346-
readonly CLOSED: number;
5347-
readonly CLOSING: number;
5348-
readonly CONNECTING: number;
5349-
readonly OPEN: number;
5346+
readonly CLOSED: 3;
5347+
readonly CLOSING: 2;
5348+
readonly CONNECTING: 0;
5349+
readonly OPEN: 1;
53505350
};
53515351

53525352
/** This ServiceWorker API interface represents the scope of a service worker client that is a document in a browser context, controlled by an active worker. The service worker client independently selects and uses a service worker for its own loading and sub-resources. */

baselines/sharedworker.generated.d.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1437,9 +1437,9 @@ interface EventSource extends EventTarget {
14371437
readonly withCredentials: boolean;
14381438
/** Aborts any instances of the fetch algorithm started for this EventSource object, and sets the readyState attribute to CLOSED. */
14391439
close(): void;
1440-
readonly CLOSED: number;
1441-
readonly CONNECTING: number;
1442-
readonly OPEN: number;
1440+
readonly CLOSED: 2;
1441+
readonly CONNECTING: 0;
1442+
readonly OPEN: 1;
14431443
addEventListener<K extends keyof EventSourceEventMap>(type: K, listener: (this: EventSource, ev: EventSourceEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
14441444
addEventListener(type: string, listener: (this: EventSource, event: MessageEvent) => any, options?: boolean | AddEventListenerOptions): void;
14451445
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
@@ -1451,9 +1451,9 @@ interface EventSource extends EventTarget {
14511451
declare var EventSource: {
14521452
prototype: EventSource;
14531453
new(url: string | URL, eventSourceInitDict?: EventSourceInit): EventSource;
1454-
readonly CLOSED: number;
1455-
readonly CONNECTING: number;
1456-
readonly OPEN: number;
1454+
readonly CLOSED: 2;
1455+
readonly CONNECTING: 0;
1456+
readonly OPEN: 1;
14571457
};
14581458

14591459
/** EventTarget is a DOM interface implemented by objects that can receive events and may have listeners for them. */
@@ -1534,9 +1534,9 @@ interface FileReader extends EventTarget {
15341534
readAsBinaryString(blob: Blob): void;
15351535
readAsDataURL(blob: Blob): void;
15361536
readAsText(blob: Blob, encoding?: string): void;
1537-
readonly DONE: number;
1538-
readonly EMPTY: number;
1539-
readonly LOADING: number;
1537+
readonly DONE: 2;
1538+
readonly EMPTY: 0;
1539+
readonly LOADING: 1;
15401540
addEventListener<K extends keyof FileReaderEventMap>(type: K, listener: (this: FileReader, ev: FileReaderEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
15411541
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
15421542
removeEventListener<K extends keyof FileReaderEventMap>(type: K, listener: (this: FileReader, ev: FileReaderEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -1546,9 +1546,9 @@ interface FileReader extends EventTarget {
15461546
declare var FileReader: {
15471547
prototype: FileReader;
15481548
new(): FileReader;
1549-
readonly DONE: number;
1550-
readonly EMPTY: number;
1551-
readonly LOADING: number;
1549+
readonly DONE: 2;
1550+
readonly EMPTY: 0;
1551+
readonly LOADING: 1;
15521552
};
15531553

15541554
/** Allows to read File or Blob objects in a synchronous way. */
@@ -5194,10 +5194,10 @@ interface WebSocket extends EventTarget {
51945194
close(code?: number, reason?: string): void;
51955195
/** Transmits data using the WebSocket connection. data can be a string, a Blob, an ArrayBuffer, or an ArrayBufferView. */
51965196
send(data: string | ArrayBufferLike | Blob | ArrayBufferView): void;
5197-
readonly CLOSED: number;
5198-
readonly CLOSING: number;
5199-
readonly CONNECTING: number;
5200-
readonly OPEN: number;
5197+
readonly CLOSED: 3;
5198+
readonly CLOSING: 2;
5199+
readonly CONNECTING: 0;
5200+
readonly OPEN: 1;
52015201
addEventListener<K extends keyof WebSocketEventMap>(type: K, listener: (this: WebSocket, ev: WebSocketEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
52025202
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
52035203
removeEventListener<K extends keyof WebSocketEventMap>(type: K, listener: (this: WebSocket, ev: WebSocketEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -5207,10 +5207,10 @@ interface WebSocket extends EventTarget {
52075207
declare var WebSocket: {
52085208
prototype: WebSocket;
52095209
new(url: string | URL, protocols?: string | string[]): WebSocket;
5210-
readonly CLOSED: number;
5211-
readonly CLOSING: number;
5212-
readonly CONNECTING: number;
5213-
readonly OPEN: number;
5210+
readonly CLOSED: 3;
5211+
readonly CLOSING: 2;
5212+
readonly CONNECTING: 0;
5213+
readonly OPEN: 1;
52145214
};
52155215

52165216
interface WindowOrWorkerGlobalScope {

baselines/webworker.generated.d.ts

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1558,9 +1558,9 @@ interface EventSource extends EventTarget {
15581558
readonly withCredentials: boolean;
15591559
/** Aborts any instances of the fetch algorithm started for this EventSource object, and sets the readyState attribute to CLOSED. */
15601560
close(): void;
1561-
readonly CLOSED: number;
1562-
readonly CONNECTING: number;
1563-
readonly OPEN: number;
1561+
readonly CLOSED: 2;
1562+
readonly CONNECTING: 0;
1563+
readonly OPEN: 1;
15641564
addEventListener<K extends keyof EventSourceEventMap>(type: K, listener: (this: EventSource, ev: EventSourceEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
15651565
addEventListener(type: string, listener: (this: EventSource, event: MessageEvent) => any, options?: boolean | AddEventListenerOptions): void;
15661566
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
@@ -1572,9 +1572,9 @@ interface EventSource extends EventTarget {
15721572
declare var EventSource: {
15731573
prototype: EventSource;
15741574
new(url: string | URL, eventSourceInitDict?: EventSourceInit): EventSource;
1575-
readonly CLOSED: number;
1576-
readonly CONNECTING: number;
1577-
readonly OPEN: number;
1575+
readonly CLOSED: 2;
1576+
readonly CONNECTING: 0;
1577+
readonly OPEN: 1;
15781578
};
15791579

15801580
/** EventTarget is a DOM interface implemented by objects that can receive events and may have listeners for them. */
@@ -1694,9 +1694,9 @@ interface FileReader extends EventTarget {
16941694
readAsBinaryString(blob: Blob): void;
16951695
readAsDataURL(blob: Blob): void;
16961696
readAsText(blob: Blob, encoding?: string): void;
1697-
readonly DONE: number;
1698-
readonly EMPTY: number;
1699-
readonly LOADING: number;
1697+
readonly DONE: 2;
1698+
readonly EMPTY: 0;
1699+
readonly LOADING: 1;
17001700
addEventListener<K extends keyof FileReaderEventMap>(type: K, listener: (this: FileReader, ev: FileReaderEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
17011701
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
17021702
removeEventListener<K extends keyof FileReaderEventMap>(type: K, listener: (this: FileReader, ev: FileReaderEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -1706,9 +1706,9 @@ interface FileReader extends EventTarget {
17061706
declare var FileReader: {
17071707
prototype: FileReader;
17081708
new(): FileReader;
1709-
readonly DONE: number;
1710-
readonly EMPTY: number;
1711-
readonly LOADING: number;
1709+
readonly DONE: 2;
1710+
readonly EMPTY: 0;
1711+
readonly LOADING: 1;
17121712
};
17131713

17141714
/** Allows to read File or Blob objects in a synchronous way. */
@@ -5484,10 +5484,10 @@ interface WebSocket extends EventTarget {
54845484
close(code?: number, reason?: string): void;
54855485
/** Transmits data using the WebSocket connection. data can be a string, a Blob, an ArrayBuffer, or an ArrayBufferView. */
54865486
send(data: string | ArrayBufferLike | Blob | ArrayBufferView): void;
5487-
readonly CLOSED: number;
5488-
readonly CLOSING: number;
5489-
readonly CONNECTING: number;
5490-
readonly OPEN: number;
5487+
readonly CLOSED: 3;
5488+
readonly CLOSING: 2;
5489+
readonly CONNECTING: 0;
5490+
readonly OPEN: 1;
54915491
addEventListener<K extends keyof WebSocketEventMap>(type: K, listener: (this: WebSocket, ev: WebSocketEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
54925492
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
54935493
removeEventListener<K extends keyof WebSocketEventMap>(type: K, listener: (this: WebSocket, ev: WebSocketEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
@@ -5497,10 +5497,10 @@ interface WebSocket extends EventTarget {
54975497
declare var WebSocket: {
54985498
prototype: WebSocket;
54995499
new(url: string | URL, protocols?: string | string[]): WebSocket;
5500-
readonly CLOSED: number;
5501-
readonly CLOSING: number;
5502-
readonly CONNECTING: number;
5503-
readonly OPEN: number;
5500+
readonly CLOSED: 3;
5501+
readonly CLOSING: 2;
5502+
readonly CONNECTING: 0;
5503+
readonly OPEN: 1;
55045504
};
55055505

55065506
/** This ServiceWorker API interface represents the scope of a service worker client that is a document in a browser context, controlled by an active worker. The service worker client independently selects and uses a service worker for its own loading and sub-resources. */

inputfiles/overridingTypes.jsonc

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1801,6 +1801,37 @@
18011801
"type": "MessageEvent"
18021802
}
18031803
]
1804+
},
1805+
"constants": {
1806+
"constant": {
1807+
"CONNECTING": {
1808+
"overrideType": "0"
1809+
},
1810+
"OPEN": {
1811+
"overrideType": "1"
1812+
},
1813+
"CLOSING": {
1814+
"overrideType": "2"
1815+
},
1816+
"CLOSED": {
1817+
"overrideType": "3"
1818+
}
1819+
}
1820+
}
1821+
},
1822+
"EventSource": {
1823+
"constants": {
1824+
"constant": {
1825+
"CONNECTING": {
1826+
"overrideType": "0"
1827+
},
1828+
"OPEN": {
1829+
"overrideType": "1"
1830+
},
1831+
"CLOSED": {
1832+
"overrideType": "2"
1833+
}
1834+
}
18041835
}
18051836
},
18061837
"HTMLTableRowElement": {
@@ -1880,6 +1911,19 @@
18801911
}
18811912
},
18821913
"FileReader": {
1914+
"constants": {
1915+
"constant": {
1916+
"EMPTY": {
1917+
"overrideType": "0"
1918+
},
1919+
"LOADING": {
1920+
"overrideType": "1"
1921+
},
1922+
"DONE": {
1923+
"overrideType": "2"
1924+
}
1925+
}
1926+
},
18831927
"events": {
18841928
"event": [
18851929
{

0 commit comments

Comments
 (0)