Skip to content

Commit 9e88bfd

Browse files
committed
Revert previous changes to Window.location to avoid breaking existing uses
1 parent 26b41a2 commit 9e88bfd

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

baselines/dom.generated.d.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3654,7 +3654,7 @@ interface Document extends Node, GlobalEventHandlers, ParentNode, DocumentEvent
36543654
/**
36553655
* Contains information about the current URL.
36563656
*/
3657-
location: Location | string;
3657+
location: Location;
36583658
msCSSOMElementFloatMetrics: boolean;
36593659
msCapsLockWarningOff: boolean;
36603660
/**
@@ -14909,7 +14909,7 @@ interface Window extends EventTarget, WindowTimers, WindowSessionStorage, Window
1490914909
readonly innerWidth: number;
1491014910
readonly isSecureContext: boolean;
1491114911
readonly length: number;
14912-
location: Location | string;
14912+
location: Location;
1491314913
readonly locationbar: BarProp;
1491414914
readonly menubar: BarProp;
1491514915
readonly msContentScript: ExtensionScriptApis;
@@ -15718,7 +15718,7 @@ declare var innerHeight: number;
1571815718
declare var innerWidth: number;
1571915719
declare var isSecureContext: boolean;
1572015720
declare var length: number;
15721-
declare var location: Location | string;
15721+
declare var location: Location;
1572215722
declare var locationbar: BarProp;
1572315723
declare var menubar: BarProp;
1572415724
declare var msContentScript: ExtensionScriptApis;

inputfiles/overridingTypes.json

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,7 @@
200200
"override-type": "(ev: TouchEvent) => any"
201201
},
202202
"location": {
203-
"name": "location",
204-
"read-only": null,
205-
"override-type": "Location | string"
203+
"read-only": 0
206204
}
207205
}
208206
},
@@ -336,9 +334,7 @@
336334
"override-type": "HTMLCollectionOf<HTMLScriptElement>"
337335
},
338336
"location": {
339-
"name": "location",
340-
"read-only": 0,
341-
"override-type": "Location | string"
337+
"read-only": 0
342338
}
343339
}
344340
}

0 commit comments

Comments
 (0)