Skip to content

Commit 85ea749

Browse files
dsiffordsandersn
authored andcommitted
fix inaccurate overrides for CSSOM (#734)
1 parent 1332a5b commit 85ea749

File tree

2 files changed

+7
-60
lines changed

2 files changed

+7
-60
lines changed

baselines/dom.generated.d.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5249,8 +5249,8 @@ interface Element extends Node, Animatable, ChildNode, InnerHTML, NonDocumentTyp
52495249
getAttributeNames(): string[];
52505250
getAttributeNode(name: string): Attr | null;
52515251
getAttributeNodeNS(namespaceURI: string, localName: string): Attr | null;
5252-
getBoundingClientRect(): ClientRect | DOMRect;
5253-
getClientRects(): ClientRectList | DOMRectList;
5252+
getBoundingClientRect(): DOMRect;
5253+
getClientRects(): DOMRectList;
52545254
/**
52555255
* Returns a HTMLCollection of the elements in the object on which the method was invoked (a document or an element) that have all the classes given by classNames. The classNames argument is interpreted as a space-separated list of classes.
52565256
*/
@@ -9807,11 +9807,11 @@ declare var IntersectionObserver: {
98079807

98089808
/** This Intersection Observer API interface describes the intersection between the target element and its root container at a specific moment of transition. */
98099809
interface IntersectionObserverEntry {
9810-
readonly boundingClientRect: ClientRect | DOMRect;
9810+
readonly boundingClientRect: DOMRectReadOnly;
98119811
readonly intersectionRatio: number;
9812-
readonly intersectionRect: ClientRect | DOMRect;
9812+
readonly intersectionRect: DOMRectReadOnly;
98139813
readonly isIntersecting: boolean;
9814-
readonly rootBounds: ClientRect | DOMRect | null;
9814+
readonly rootBounds: DOMRectReadOnly | null;
98159815
readonly target: Element;
98169816
readonly time: number;
98179817
}
@@ -12623,8 +12623,8 @@ interface Range extends AbstractRange {
1262312623
deleteContents(): void;
1262412624
detach(): void;
1262512625
extractContents(): DocumentFragment;
12626-
getBoundingClientRect(): ClientRect | DOMRect;
12627-
getClientRects(): ClientRectList | DOMRectList;
12626+
getBoundingClientRect(): DOMRect;
12627+
getClientRects(): DOMRectList;
1262812628
insertNode(node: Node): void;
1262912629
/**
1263012630
* Returns whether range intersects node.

inputfiles/overridingTypes.json

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,18 +1189,6 @@
11891189
"name": "Element",
11901190
"methods": {
11911191
"method": {
1192-
"getBoundingClientRect": {
1193-
"name": "getBoundingClientRect",
1194-
"override-signatures": [
1195-
"getBoundingClientRect(): ClientRect | DOMRect"
1196-
]
1197-
},
1198-
"getClientRects": {
1199-
"name": "getClientRects",
1200-
"override-signatures": [
1201-
"getClientRects(): ClientRectList | DOMRectList"
1202-
]
1203-
},
12041192
"getAttributeNodeNS": {
12051193
"name": "getAttributeNodeNS",
12061194
"override-signatures": [
@@ -1725,47 +1713,6 @@
17251713
]
17261714
}
17271715
},
1728-
"IntersectionObserverEntry": {
1729-
"name": "IntersectionObserverEntry",
1730-
"properties": {
1731-
"property": {
1732-
"boundingClientRect": {
1733-
"name": "boundingClientRect",
1734-
"read-only": 1,
1735-
"override-type": "ClientRect | DOMRect"
1736-
},
1737-
"intersectionRect": {
1738-
"name": "intersectionRect",
1739-
"read-only": 1,
1740-
"override-type": "ClientRect | DOMRect"
1741-
},
1742-
"rootBounds": {
1743-
"name": "rootBounds",
1744-
"read-only": 1,
1745-
"override-type": "ClientRect | DOMRect"
1746-
}
1747-
}
1748-
}
1749-
},
1750-
"Range": {
1751-
"name": "Range",
1752-
"methods": {
1753-
"method": {
1754-
"getBoundingClientRect": {
1755-
"name": "getBoundingClientRect",
1756-
"override-signatures": [
1757-
"getBoundingClientRect(): ClientRect | DOMRect"
1758-
]
1759-
},
1760-
"getClientRects": {
1761-
"name": "getClientRects",
1762-
"override-signatures": [
1763-
"getClientRects(): ClientRectList | DOMRectList"
1764-
]
1765-
}
1766-
}
1767-
}
1768-
},
17691716
"WebSocket": {
17701717
"name": "WebSocket",
17711718
"methods": {

0 commit comments

Comments
 (0)