Skip to content

Commit 509d578

Browse files
authored
Use proper interfaces for hashchange/gamepad events (#1104)
* Use HashChangeEvent interface for hashchange events Fixes #1077. * gamepad fix
1 parent 302ec59 commit 509d578

File tree

2 files changed

+21
-9
lines changed

2 files changed

+21
-9
lines changed

baselines/dom.generated.d.ts

+9-9
Original file line numberDiff line numberDiff line change
@@ -16127,9 +16127,9 @@ interface WindowEventHandlersEventMap {
1612716127
"afterprint": Event;
1612816128
"beforeprint": Event;
1612916129
"beforeunload": BeforeUnloadEvent;
16130-
"gamepadconnected": Event;
16131-
"gamepaddisconnected": Event;
16132-
"hashchange": Event;
16130+
"gamepadconnected": GamepadEvent;
16131+
"gamepaddisconnected": GamepadEvent;
16132+
"hashchange": HashChangeEvent;
1613316133
"languagechange": Event;
1613416134
"message": MessageEvent;
1613516135
"messageerror": MessageEvent;
@@ -16148,9 +16148,9 @@ interface WindowEventHandlers {
1614816148
onafterprint: ((this: WindowEventHandlers, ev: Event) => any) | null;
1614916149
onbeforeprint: ((this: WindowEventHandlers, ev: Event) => any) | null;
1615016150
onbeforeunload: ((this: WindowEventHandlers, ev: BeforeUnloadEvent) => any) | null;
16151-
ongamepadconnected: ((this: WindowEventHandlers, ev: Event) => any) | null;
16152-
ongamepaddisconnected: ((this: WindowEventHandlers, ev: Event) => any) | null;
16153-
onhashchange: ((this: WindowEventHandlers, ev: Event) => any) | null;
16151+
ongamepadconnected: ((this: WindowEventHandlers, ev: GamepadEvent) => any) | null;
16152+
ongamepaddisconnected: ((this: WindowEventHandlers, ev: GamepadEvent) => any) | null;
16153+
onhashchange: ((this: WindowEventHandlers, ev: HashChangeEvent) => any) | null;
1615416154
onlanguagechange: ((this: WindowEventHandlers, ev: Event) => any) | null;
1615516155
onmessage: ((this: WindowEventHandlers, ev: MessageEvent) => any) | null;
1615616156
onmessageerror: ((this: WindowEventHandlers, ev: MessageEvent) => any) | null;
@@ -17426,9 +17426,9 @@ declare var onwheel: ((this: Window, ev: WheelEvent) => any) | null;
1742617426
declare var onafterprint: ((this: Window, ev: Event) => any) | null;
1742717427
declare var onbeforeprint: ((this: Window, ev: Event) => any) | null;
1742817428
declare var onbeforeunload: ((this: Window, ev: BeforeUnloadEvent) => any) | null;
17429-
declare var ongamepadconnected: ((this: Window, ev: Event) => any) | null;
17430-
declare var ongamepaddisconnected: ((this: Window, ev: Event) => any) | null;
17431-
declare var onhashchange: ((this: Window, ev: Event) => any) | null;
17429+
declare var ongamepadconnected: ((this: Window, ev: GamepadEvent) => any) | null;
17430+
declare var ongamepaddisconnected: ((this: Window, ev: GamepadEvent) => any) | null;
17431+
declare var onhashchange: ((this: Window, ev: HashChangeEvent) => any) | null;
1743217432
declare var onlanguagechange: ((this: Window, ev: Event) => any) | null;
1743317433
declare var onmessage: ((this: Window, ev: MessageEvent) => any) | null;
1743417434
declare var onmessageerror: ((this: Window, ev: MessageEvent) => any) | null;

inputfiles/addedTypes.jsonc

+12
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,18 @@
200200
"name": "beforeunload",
201201
"type": "BeforeUnloadEvent"
202202
},
203+
{
204+
"name": "gamepadconnected",
205+
"type": "GamepadEvent"
206+
},
207+
{
208+
"name": "gamepaddisconnected",
209+
"type": "GamepadEvent"
210+
},
211+
{
212+
"name": "hashchange",
213+
"type": "HashChangeEvent"
214+
},
203215
{
204216
"name": "message",
205217
"type": "MessageEvent"

0 commit comments

Comments
 (0)