Skip to content

Commit 40c0e96

Browse files
AndaristAndarist
committed
Disallow clearing timers without no argument at all
1 parent 0b42a3d commit 40c0e96

File tree

5 files changed

+48
-16
lines changed

5 files changed

+48
-16
lines changed

‎baselines/dom.generated.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16646,8 +16646,8 @@ interface WindowOrWorkerGlobalScope {
1664616646
readonly performance: Performance;
1664716647
atob(data: string): string;
1664816648
btoa(data: string): string;
16649-
clearInterval(id?: number): void;
16650-
clearTimeout(id?: number): void;
16649+
clearInterval(id: number | undefined): void;
16650+
clearTimeout(id: number | undefined): void;
1665116651
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
1665216652
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
1665316653
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -17953,8 +17953,8 @@ declare var origin: string;
1795317953
declare var performance: Performance;
1795417954
declare function atob(data: string): string;
1795517955
declare function btoa(data: string): string;
17956-
declare function clearInterval(id?: number): void;
17957-
declare function clearTimeout(id?: number): void;
17956+
declare function clearInterval(id: number | undefined): void;
17957+
declare function clearTimeout(id: number | undefined): void;
1795817958
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
1795917959
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
1796017960
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

‎baselines/serviceworker.generated.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5114,8 +5114,8 @@ interface WindowOrWorkerGlobalScope {
51145114
readonly performance: Performance;
51155115
atob(data: string): string;
51165116
btoa(data: string): string;
5117-
clearInterval(id?: number): void;
5118-
clearTimeout(id?: number): void;
5117+
clearInterval(id: number | undefined): void;
5118+
clearTimeout(id: number | undefined): void;
51195119
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
51205120
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
51215121
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -5484,8 +5484,8 @@ declare var origin: string;
54845484
declare var performance: Performance;
54855485
declare function atob(data: string): string;
54865486
declare function btoa(data: string): string;
5487-
declare function clearInterval(id?: number): void;
5488-
declare function clearTimeout(id?: number): void;
5487+
declare function clearInterval(id: number | undefined): void;
5488+
declare function clearTimeout(id: number | undefined): void;
54895489
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
54905490
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
54915491
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

‎baselines/sharedworker.generated.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4968,8 +4968,8 @@ interface WindowOrWorkerGlobalScope {
49684968
readonly performance: Performance;
49694969
atob(data: string): string;
49704970
btoa(data: string): string;
4971-
clearInterval(id?: number): void;
4972-
clearTimeout(id?: number): void;
4971+
clearInterval(id: number | undefined): void;
4972+
clearTimeout(id: number | undefined): void;
49734973
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
49744974
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
49754975
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -5500,8 +5500,8 @@ declare var origin: string;
55005500
declare var performance: Performance;
55015501
declare function atob(data: string): string;
55025502
declare function btoa(data: string): string;
5503-
declare function clearInterval(id?: number): void;
5504-
declare function clearTimeout(id?: number): void;
5503+
declare function clearInterval(id: number | undefined): void;
5504+
declare function clearTimeout(id: number | undefined): void;
55055505
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
55065506
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
55075507
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

‎baselines/webworker.generated.d.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5248,8 +5248,8 @@ interface WindowOrWorkerGlobalScope {
52485248
readonly performance: Performance;
52495249
atob(data: string): string;
52505250
btoa(data: string): string;
5251-
clearInterval(id?: number): void;
5252-
clearTimeout(id?: number): void;
5251+
clearInterval(id: number | undefined): void;
5252+
clearTimeout(id: number | undefined): void;
52535253
createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
52545254
createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
52555255
fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;
@@ -5788,8 +5788,8 @@ declare var origin: string;
57885788
declare var performance: Performance;
57895789
declare function atob(data: string): string;
57905790
declare function btoa(data: string): string;
5791-
declare function clearInterval(id?: number): void;
5792-
declare function clearTimeout(id?: number): void;
5791+
declare function clearInterval(id: number | undefined): void;
5792+
declare function clearTimeout(id: number | undefined): void;
57935793
declare function createImageBitmap(image: ImageBitmapSource, options?: ImageBitmapOptions): Promise<ImageBitmap>;
57945794
declare function createImageBitmap(image: ImageBitmapSource, sx: number, sy: number, sw: number, sh: number, options?: ImageBitmapOptions): Promise<ImageBitmap>;
57955795
declare function fetch(input: RequestInfo | URL, init?: RequestInit): Promise<Response>;

‎inputfiles/overridingTypes.jsonc

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,38 @@
218218
}
219219
}
220220
}
221+
},
222+
"WindowOrWorkerGlobalScope": {
223+
"methods": {
224+
"method": {
225+
"clearInterval": {
226+
"signature": {
227+
"0": {
228+
"param": [
229+
{
230+
"name": "id",
231+
"optional": false,
232+
"overrideType": "number | undefined"
233+
}
234+
]
235+
}
236+
}
237+
},
238+
"clearTimeout": {
239+
"signature": {
240+
"0": {
241+
"param": [
242+
{
243+
"name": "id",
244+
"optional": false,
245+
"overrideType": "number | undefined"
246+
}
247+
]
248+
}
249+
}
250+
}
251+
}
252+
}
221253
}
222254
}
223255
},

0 commit comments

Comments
 (0)