Skip to content

Commit 374a335

Browse files
author
Orta Therox
authored
Merge pull request #965 from noelebrun/service-worker-register-url
Allow URL in ServiceWorkerContainer#register
2 parents 77813e6 + cc29008 commit 374a335

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

baselines/dom.generated.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -14987,7 +14987,7 @@ interface ServiceWorkerContainer extends EventTarget {
1498714987
readonly ready: Promise<ServiceWorkerRegistration>;
1498814988
getRegistration(clientURL?: string): Promise<ServiceWorkerRegistration | undefined>;
1498914989
getRegistrations(): Promise<ReadonlyArray<ServiceWorkerRegistration>>;
14990-
register(scriptURL: string, options?: RegistrationOptions): Promise<ServiceWorkerRegistration>;
14990+
register(scriptURL: string | URL, options?: RegistrationOptions): Promise<ServiceWorkerRegistration>;
1499114991
startMessages(): void;
1499214992
addEventListener<K extends keyof ServiceWorkerContainerEventMap>(type: K, listener: (this: ServiceWorkerContainer, ev: ServiceWorkerContainerEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
1499314993
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;

baselines/webworker.generated.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2891,7 +2891,7 @@ interface ServiceWorkerContainer extends EventTarget {
28912891
readonly ready: Promise<ServiceWorkerRegistration>;
28922892
getRegistration(clientURL?: string): Promise<ServiceWorkerRegistration | undefined>;
28932893
getRegistrations(): Promise<ReadonlyArray<ServiceWorkerRegistration>>;
2894-
register(scriptURL: string, options?: RegistrationOptions): Promise<ServiceWorkerRegistration>;
2894+
register(scriptURL: string | URL, options?: RegistrationOptions): Promise<ServiceWorkerRegistration>;
28952895
startMessages(): void;
28962896
addEventListener<K extends keyof ServiceWorkerContainerEventMap>(type: K, listener: (this: ServiceWorkerContainer, ev: ServiceWorkerContainerEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
28972897
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;

inputfiles/overridingTypes.json

+6
Original file line numberDiff line numberDiff line change
@@ -1577,6 +1577,12 @@
15771577
"override-signatures": [
15781578
"getRegistration(clientURL?: string): Promise<ServiceWorkerRegistration | undefined>"
15791579
]
1580+
},
1581+
"register": {
1582+
"name": "register",
1583+
"override-signatures": [
1584+
"register(scriptURL: string | URL, options?: RegistrationOptions): Promise<ServiceWorkerRegistration>"
1585+
]
15801586
}
15811587
}
15821588
},

0 commit comments

Comments
 (0)