Merged PR 191366: Fix application context in bootstrap case

Fix application context in bootstrap case

Author: Shahak Yosef

dist/powerbi-client.d.ts

@@ -1,4 +1,4 @@
-// powerbi-client v2.18.4
+// powerbi-client v2.18.5
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 declare module "config" {

dist/powerbi.js

@@ -1,6 +1,6 @@
 {
   "name": "powerbi-client",
-  "version": "2.18.4",
+  "version": "2.18.5",
   "description": "JavaScript library for embedding Power BI into your apps. Provides service which makes it easy to embed different types of components and an object model which allows easy interaction with these components such as changing pages, applying filters, and responding to data selection.",
   "main": "dist/powerbi.js",
   "types": "dist/powerbi-client.d.ts",

dist/powerbi.min.js

@@ -3,7 +3,7 @@
 
 /** @ignore *//** */
 const config = {
-  version: '2.18.4',
+  version: '2.18.5',
   type: 'js'
 };
 

package.json

@@ -227,15 +227,12 @@ export abstract class Embed {
     this.commands = [];
     this.groups = [];
 
-    const registerQueryCallback = !!(<IEmbedConfiguration>config).eventHooks?.applicationContextProvider;
-    delete (<IEmbedConfiguration>config).eventHooks;
-
     this.populateConfig(config, isBootstrap);
 
     if (this.embedtype === 'create') {
-      this.setIframe(false /* set EventListener to call create() on 'load' event*/, phasedRender, isBootstrap, registerQueryCallback);
+      this.setIframe(false /* set EventListener to call create() on 'load' event*/, phasedRender, isBootstrap);
     } else {
-      this.setIframe(true /* set EventListener to call load() on 'load' event*/, phasedRender, isBootstrap, registerQueryCallback);
+      this.setIframe(true /* set EventListener to call load() on 'load' event*/, phasedRender, isBootstrap);
     }
   }
 
@@ -540,6 +537,11 @@ export abstract class Embed {
       this.config.accessToken = this.getAccessToken(this.service.accessToken);
     }
 
+    const registerQueryCallback = !!(<IEmbedConfiguration>this.config).eventHooks?.applicationContextProvider;
+    delete (<IEmbedConfiguration>this.config).eventHooks;
+    if (registerQueryCallback && this.embedtype === "report")
+      this.config.embedUrl = addParamToUrl(this.config.embedUrl, "registerQueryCallback", "true");
+
     this.configChanged(isBootstrap);
   }
 
@@ -710,9 +712,6 @@ export abstract class Embed {
       const iframeContent = document.createElement("iframe");
       let embedUrl = this.config.uniqueId ? addParamToUrl(this.config.embedUrl, 'uid', this.config.uniqueId) : this.config.embedUrl;
 
-      if (!isBootstrap && registerQueryCallback)
-        embedUrl = addParamToUrl(embedUrl, "registerQueryCallback", "true");
-
       iframeContent.style.width = '100%';
       iframeContent.style.height = '100%';
       iframeContent.setAttribute("src", embedUrl);

src/config.ts

@@ -326,6 +326,7 @@ export class Service implements IService {
    * @param {IBootstrapEmbedConfiguration} config: a bootstrap config which is an embed config without access token.
    */
   bootstrap(element: HTMLElement, config: IComponentEmbedConfiguration | IBootstrapEmbedConfiguration): Embed {
+    this.registerApplicationContextHook(config as IEmbedConfiguration);
     return this.embedInternal(element, config, /* phasedRender */ false, /* isBootstrap */ true);
   }
 
@@ -451,6 +452,10 @@ export class Service implements IService {
       return;
     }
 
+    if (config?.type.toLowerCase() !== "report") {
+      throw new Error("applicationContextProvider is only supported in report embed");
+    }
+
     if (typeof applicationContextProvider !== 'function') {
       throw new Error("applicationContextProvider must be a function");
     }