Skip to content

Commit 09894c8

Browse files
committed
Merged PR 134898: Fixed spellings
Note: Changes in **powerbi-client.d.ts > module "visual"** are due to the previous completed PR
1 parent 0071be7 commit 09894c8

File tree

7 files changed

+47
-16
lines changed

7 files changed

+47
-16
lines changed

dist/powerbi-client.d.ts

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ declare module "util" {
4747
*/
4848
export function createRandomString(): string;
4949
/**
50-
* Generates a 20 charachter uuid.
50+
* Generates a 20 character uuid.
5151
*
5252
* @export
5353
* @returns {string}
@@ -597,7 +597,7 @@ declare module "visualDescriptor" {
597597
*/
598598
type: string;
599599
/**
600-
* The visual layout: position, size and visiblity.
600+
* The visual layout: position, size and visibility.
601601
*
602602
* @type {string}
603603
*/
@@ -812,7 +812,7 @@ declare module "page" {
812812
/**
813813
* Makes the current page the active page of the report.
814814
*
815-
* ```javascripot
815+
* ```javascript
816816
* page.setActive();
817817
* ```
818818
*
@@ -1437,6 +1437,7 @@ declare module "visual" {
14371437
import { Page } from "page";
14381438
import { VisualDescriptor } from "visualDescriptor";
14391439
import { IHttpPostMessageResponse } from 'http-post-message';
1440+
import { IReportLoadConfiguration } from 'powerbi-models';
14401441
/**
14411442
* The Power BI Visual embed component
14421443
*
@@ -1450,6 +1451,8 @@ declare module "visual" {
14501451
static GetPagesNotSupportedError: string;
14511452
/** @hidden */
14521453
static SetPageNotSupportedError: string;
1454+
/** @hidden */
1455+
static RenderNotSupportedError: string;
14531456
/**
14541457
* Creates an instance of a Power BI Single Visual.
14551458
*
@@ -1459,6 +1462,9 @@ declare module "visual" {
14591462
* @hidden
14601463
*/
14611464
constructor(service: service.Service, element: HTMLElement, baseConfig: embed.IEmbedConfigurationBase, phasedRender?: boolean, isBootstrap?: boolean, iframe?: HTMLIFrameElement);
1465+
/**
1466+
* @hidden
1467+
*/
14621468
load(phasedRender?: boolean): Promise<void>;
14631469
/**
14641470
* Gets the list of pages within the report - not supported in visual embed.
@@ -1473,6 +1479,13 @@ declare module "visual" {
14731479
* @returns {Promise<IHttpPostMessageResponse<void>>}
14741480
*/
14751481
setPage(pageName: string): Promise<IHttpPostMessageResponse<void>>;
1482+
/**
1483+
* Render a preloaded report, using phased embedding API
1484+
*
1485+
* @hidden
1486+
* @returns {Promise<void>}
1487+
*/
1488+
render(config?: IReportLoadConfiguration | embed.IReportEmbedConfiguration): Promise<void>;
14761489
/**
14771490
* Gets the embedded visual descriptor object that contains the visual name, type, etc.
14781491
*
@@ -1620,7 +1633,7 @@ declare module "service" {
16201633
private config;
16211634
/** A list of Dashboard, Report and Tile components that have been embedded using this service instance. */
16221635
private embeds;
1623-
/** TODO: Look for way to make hpm private without sacraficing ease of maitenance. This should be private but in embed needs to call methods.
1636+
/** TODO: Look for way to make hpm private without sacrificing ease of maintenance. This should be private but in embed needs to call methods.
16241637
* @hidden
16251638
*/
16261639
hpm: hpm.HttpPostMessage;

dist/powerbi.js

Lines changed: 22 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/powerbi.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ export class Page implements IPageNode, IFilterable {
148148
/**
149149
* Makes the current page the active page of the report.
150150
*
151-
* ```javascripot
151+
* ```javascript
152152
* page.setActive();
153153
* ```
154154
*

src/service.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ export class Service implements IService {
118118
/** A list of Dashboard, Report and Tile components that have been embedded using this service instance. */
119119
private embeds: embed.Embed[];
120120

121-
/** TODO: Look for way to make hpm private without sacraficing ease of maitenance. This should be private but in embed needs to call methods.
121+
/** TODO: Look for way to make hpm private without sacrificing ease of maintenance. This should be private but in embed needs to call methods.
122122
* @hidden
123123
*/
124124
hpm: hpm.HttpPostMessage;
@@ -383,7 +383,7 @@ export class Service implements IService {
383383
private embedExisting(element: IPowerBiElement, config: IComponentEmbedConfiguration | embed.IEmbedConfigurationBase, phasedRender?: boolean): embed.Embed {
384384
const component = utils.find(x => x.element === element, this.embeds);
385385
if (!component) {
386-
throw new Error(`Attempted to embed using config ${JSON.stringify(config)} on element ${element.outerHTML} which already has embedded comopnent associated, but could not find the existing comopnent in the list of active components. This could indicate the embeds list is out of sync with the DOM, or the component is referencing the incorrect HTML element.`);
386+
throw new Error(`Attempted to embed using config ${JSON.stringify(config)} on element ${element.outerHTML} which already has embedded component associated, but could not find the existing component in the list of active components. This could indicate the embeds list is out of sync with the DOM, or the component is referencing the incorrect HTML element.`);
387387
}
388388

389389
// TODO: Multiple embedding to the same iframe is not supported in QnA
@@ -508,7 +508,7 @@ export class Service implements IService {
508508
iframe.remove();
509509
}
510510
else {
511-
/** Workaround for IE: unhandled rejection TypeError: object doesn't support propert or method 'remove' */
511+
/** Workaround for IE: unhandled rejection TypeError: object doesn't support property or method 'remove' */
512512
iframe.parentElement.removeChild(iframe);
513513
}
514514
}

src/util.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ export function createRandomString(): string {
110110
}
111111

112112
/**
113-
* Generates a 20 charachter uuid.
113+
* Generates a 20 character uuid.
114114
*
115115
* @export
116116
* @returns {string}

src/visualDescriptor.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ export class VisualDescriptor implements IVisualNode, IFilterable {
4747
type: string;
4848

4949
/**
50-
* The visual layout: position, size and visiblity.
50+
* The visual layout: position, size and visibility.
5151
*
5252
* @type {string}
5353
*/

0 commit comments

Comments
 (0)