Skip to content

Commit d3e33d0

Browse files
authored
Use same description for same meter name in Log4j2Metrics (#4864)
Avoids having different descriptions for the same meter name as this causes issues with some integrations that expect one description for all.
1 parent 37bfdfd commit d3e33d0

File tree

1 file changed

+8
-6
lines changed
  • micrometer-core/src/main/java/io/micrometer/core/instrument/binder/logging

1 file changed

+8
-6
lines changed

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/logging/Log4j2Metrics.java

+8-6
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@ public class Log4j2Metrics implements MeterBinder, AutoCloseable {
5151

5252
private static final String METER_NAME = "log4j2.events";
5353

54+
private static final String METER_DESCRIPTION = "Number of log events";
55+
5456
private final Iterable<Tag> tags;
5557

5658
private final LoggerContext loggerContext;
@@ -156,42 +158,42 @@ class MetricsFilter extends AbstractFilter {
156158
fatalCounter = Counter.builder(METER_NAME)
157159
.tags(tags)
158160
.tags("level", "fatal")
159-
.description("Number of fatal level log events")
161+
.description(METER_DESCRIPTION)
160162
.baseUnit(BaseUnits.EVENTS)
161163
.register(registry);
162164

163165
errorCounter = Counter.builder(METER_NAME)
164166
.tags(tags)
165167
.tags("level", "error")
166-
.description("Number of error level log events")
168+
.description(METER_DESCRIPTION)
167169
.baseUnit(BaseUnits.EVENTS)
168170
.register(registry);
169171

170172
warnCounter = Counter.builder(METER_NAME)
171173
.tags(tags)
172174
.tags("level", "warn")
173-
.description("Number of warn level log events")
175+
.description(METER_DESCRIPTION)
174176
.baseUnit(BaseUnits.EVENTS)
175177
.register(registry);
176178

177179
infoCounter = Counter.builder(METER_NAME)
178180
.tags(tags)
179181
.tags("level", "info")
180-
.description("Number of info level log events")
182+
.description(METER_DESCRIPTION)
181183
.baseUnit(BaseUnits.EVENTS)
182184
.register(registry);
183185

184186
debugCounter = Counter.builder(METER_NAME)
185187
.tags(tags)
186188
.tags("level", "debug")
187-
.description("Number of debug level log events")
189+
.description(METER_DESCRIPTION)
188190
.baseUnit(BaseUnits.EVENTS)
189191
.register(registry);
190192

191193
traceCounter = Counter.builder(METER_NAME)
192194
.tags(tags)
193195
.tags("level", "trace")
194-
.description("Number of trace level log events")
196+
.description(METER_DESCRIPTION)
195197
.baseUnit(BaseUnits.EVENTS)
196198
.register(registry);
197199
}

0 commit comments

Comments
 (0)