Skip to content

Commit 33c4414

Browse files
Merge branch '1.10.x' into 1.11.x
2 parents 209cc10 + e6e61b0 commit 33c4414

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

implementations/micrometer-registry-prometheus/src/main/java/io/micrometer/prometheus/PrometheusTimer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ protected void recordNonNegative(long amount, TimeUnit unit) {
9494
max.record(nanoAmount, TimeUnit.NANOSECONDS);
9595

9696
if (histogram != null) {
97-
histogram.recordLong(TimeUnit.NANOSECONDS.convert(amount, unit));
97+
histogram.recordLong(nanoAmount);
9898
}
9999
}
100100

micrometer-core/src/main/java/io/micrometer/core/instrument/binder/logging/LogbackMetrics.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ public FilterReply decide(Marker marker, Logger logger, Level level, String form
206206
// and can return immediately and
207207
// avoid the relatively expensive ThreadLocal access below. See also logbacks
208208
// Logger.callTurboFilters().
209-
// Calling logger.isEnabledFor(level) might be sub-optimal since it cals this
209+
// Calling logger.isEnabledFor(level) might be sub-optimal since it calls this
210210
// filter again. This behavior caused a StackOverflowError in the past.
211211
if (format == null || !level.isGreaterOrEqual(logger.getEffectiveLevel())) {
212212
return FilterReply.NEUTRAL;

micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/TimeWindowFixedBoundaryHistogram.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,10 @@ void outputSummary(PrintStream printStream, double bucketScaling) {
118118

119119
String bucketFormatString = "%14.1f %10d\n";
120120

121+
FixedBoundaryHistogram currentHistogram = currentHistogram();
121122
for (int i = 0; i < buckets.length; i++) {
122123
printStream.format(Locale.US, bucketFormatString, buckets[i] / bucketScaling,
123-
currentHistogram().values.get(i));
124+
currentHistogram.values.get(i));
124125
}
125126

126127
printStream.write('\n');

micrometer-core/src/main/java/io/micrometer/core/instrument/step/StepDistributionSummary.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public class StepDistributionSummary extends AbstractDistributionSummary impleme
4747
* Create a new {@code StepDistributionSummary}.
4848
* @param id ID
4949
* @param clock clock
50-
* @param distributionStatisticConfig distribution static configuration
50+
* @param distributionStatisticConfig distribution statistic configuration
5151
* @param scale scale
5252
* @param stepMillis step in milliseconds
5353
* @param supportsAggregablePercentiles whether it supports aggregable percentiles
@@ -77,7 +77,7 @@ protected StepDistributionSummary(Id id, Clock clock, DistributionStatisticConfi
7777

7878
@Override
7979
protected void recordNonNegative(double amount) {
80-
count.add(1);
80+
count.add(1L);
8181
total.add(amount);
8282
max.record(amount);
8383
}

micrometer-core/src/main/java/io/micrometer/core/instrument/step/StepTimer.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ protected StepTimer(final Id id, final Clock clock, final DistributionStatisticC
7878
@Override
7979
protected void recordNonNegative(final long amount, final TimeUnit unit) {
8080
final long nanoAmount = (long) TimeUtils.convert(amount, unit, TimeUnit.NANOSECONDS);
81-
count.add(1);
81+
count.add(1L);
8282
total.add(nanoAmount);
8383
max.record(nanoAmount);
8484
}

0 commit comments

Comments
 (0)