Skip to content

Problems on Windows machines #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
birdofpreyru opened this issue Apr 16, 2020 · 2 comments
Closed

Problems on Windows machines #110

birdofpreyru opened this issue Apr 16, 2020 · 2 comments

Comments

@birdofpreyru
Copy link

Because of css-modules/css-modules-require-hook#119, babel-plugin-css-modules-transform does not work on Windows machines either (generates hashes different from those generated by css-loader). Part of the problem is that owner of css-modules-require-hook is not responsive (the issue and correct fix are pending for one year there). So, I am considering to fork and fix css-modules-require-hook, and wanna check with you @michalkvasnicak whether you are open to update this package to depend on my fixed version of css-module-require-hook?

@michalkvasnicak
Copy link
Owner

@birdofpreyru Hello I'm sorry I wasn't really invest my time into this package. I want to rewrite it to typescript and with babel 7 support only. I don't see any problem in supporting your library. Feel free to open PR for 1.x version to use your package.

@birdofpreyru
Copy link
Author

Nevermind, I figured out I better fork your lib and give it a full revamp in my taste. If anybody needs it, I published my version here: https://www.npmjs.com/package/@dr.pogodin/babel-plugin-css-modules-transform

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants