moving build out of constructor

Author: michaelraczycki

pymc_experimental/model_builder.py

@@ -63,7 +63,6 @@ def __init__(
         self.sample_config = sampler_config  # parameters for sampling
         self.idata = None  # inference data object
         self.data = data
-        self.build()
 
     def build(self):
         """
@@ -192,6 +191,7 @@ def load(cls, fname):
             idata.fit_data.to_dataframe(),
         )
         self.idata = idata
+        self.build()
         if self.id != idata.attrs["id"]:
             raise ValueError(
                 f"The file '{fname}' does not contain an inference data of the same model or configuration as '{self._model_type}'"
@@ -224,10 +224,8 @@ def fit(self, data: Dict[str, Union[np.ndarray, pd.DataFrame, pd.Series]] = None
 
         if data is not None:
             self.data = data
-            self._data_setter(data)
-
-        if self.basic_RVs == []:
             self.build()
+            self._data_setter(data)
 
         with self:
             self.idata = pm.sample(**self.sample_config)

pymc_experimental/tests/test_model_builder.py

@@ -84,7 +84,7 @@ def create_sample_input(cls):
     def initial_build_and_fit(check_idata=True):
         data, model_config, sampler_config = test_ModelBuilder.create_sample_input()
         model = test_ModelBuilder(model_config, sampler_config, data)
-        model.fit()
+        model.fit(data=data)
         if check_idata:
             assert model.idata is not None
             assert "posterior" in model.idata.groups()