Skip to content

Commit abc5db5

Browse files
committed
fix(generator): Write URI in sorted order to prevent SHA churn
1 parent 5ef3656 commit abc5db5

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

lib/tools/template_cache_generator.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,8 @@ printTemplateCache(Map<String, String> templateKeyMap,
8989
outSink.write(fileHeader(outputLibrary));
9090

9191
List<Future> reads = <Future>[];
92-
templateKeyMap.forEach((uri, templateFile) {
92+
templateKeyMap.keys.toList()..sort()..forEach((uri) {
93+
var templateFile = templateKeyMap[uri];
9394
reads.add(new File(templateFile).readAsString().then((fileStr) {
9495
fileStr = fileStr.replaceAll('"""', r'\"\"\"');
9596
String resultUri = uri;

test/io/template_cache_generator_spec.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ main() => describe('template_cache_generator', () {
5959
'\n'
6060
'primeTemplateCache(TemplateCache tc) {\n'
6161
'tc.put("rewritten/cssUrls/one.css", new HttpResponse(200, r"""body {}"""));\n'
62-
'tc.put("rewritten/cssUrls/two.css", new HttpResponse(200, r"""body {}"""));\n'
6362
'tc.put("rewritten/cssUrls/three.css", new HttpResponse(200, r"""body {}"""));\n'
63+
'tc.put("rewritten/cssUrls/two.css", new HttpResponse(200, r"""body {}"""));\n'
6464
'}');
6565
}).whenComplete(() {
6666
//tmpDir.deleteSync(recursive: true);

0 commit comments

Comments
 (0)