Skip to content

Commit ae282a5

Browse files
authored
fix off by one issue in line and colums (#773)
1 parent 7b1458a commit ae282a5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

formatter/sarif.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ func (l *reviveRunLog) AddResult(failure lint.Failure) {
8181
}
8282
position := failure.Position
8383
filename := position.Start.Filename
84-
line := positiveOrZero(position.Start.Line - 1) // https://docs.oasis-open.org/sarif/sarif/v2.1.0/csprd01/sarif-v2.1.0-csprd01.html#def_line
85-
column := positiveOrZero(position.Start.Column - 1) // https://docs.oasis-open.org/sarif/sarif/v2.1.0/csprd01/sarif-v2.1.0-csprd01.html#def_column
84+
line := positiveOrZero(position.Start.Line) // https://docs.oasis-open.org/sarif/sarif/v2.1.0/csprd01/sarif-v2.1.0-csprd01.html#def_line
85+
column := positiveOrZero(position.Start.Column) // https://docs.oasis-open.org/sarif/sarif/v2.1.0/csprd01/sarif-v2.1.0-csprd01.html#def_column
8686

8787
result := garif.NewResult(garif.NewMessageFromText(failure.Failure))
8888
location := garif.NewLocation().WithURI(filename).WithLineColumn(line, column)

0 commit comments

Comments
 (0)