refactor: remove redundant defer

alexandear · chavacava · commit 4c958ef739e9 · 2024-11-12T09:26:30.000+01:00
diff --git a/lint/linter.go b/lint/linter.go
@@ -109,7 +109,7 @@ func (l *Linter) Lint(packages [][]string, ruleSet []Rule, config Config) (<-cha
 				fmt.Fprintln(os.Stderr, err)
 				os.Exit(1)
 			}
-			defer wg.Done()
+			wg.Done()
 		}(packages[n], perPkgVersions[n])
 	}
 
diff --git a/lint/package.go b/lint/package.go
@@ -189,7 +189,7 @@ func (p *Package) lint(rules []Rule, config Config, failures chan Failure) {
 		wg.Add(1)
 		go (func(file *File) {
 			file.lint(rules, config, failures)
-			defer wg.Done()
+			wg.Done()
 		})(file)
 	}
 	wg.Wait()

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ func (l *Linter) Lint(packages [][]string, ruleSet []Rule, config Config) (<-cha`
`109`	`109`	`fmt.Fprintln(os.Stderr, err)`
`110`	`110`	`os.Exit(1)`
`111`	`111`	`}`
`112`		`- defer wg.Done()`
	`112`	`+ wg.Done()`
`113`	`113`	`}(packages[n], perPkgVersions[n])`
`114`	`114`	`}`
`115`	`115`
Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ func (p *Package) lint(rules []Rule, config Config, failures chan Failure) {`
`189`	`189`	`wg.Add(1)`
`190`	`190`	`go (func(file *File) {`
`191`	`191`	`file.lint(rules, config, failures)`
`192`		`- defer wg.Done()`
	`192`	`+ wg.Done()`
`193`	`193`	`})(file)`
`194`	`194`	`}`
`195`	`195`	`wg.Wait()`