refactor: apply suggestions from gopls modernize (#1282)

Author: alexandear

lint/file.go

@@ -154,7 +154,7 @@ func (f *File) disabledIntervals(rules []Rule, mustSpecifyDisableReason bool, fa
 
 		for ruleName, disabledArr := range enabledDisabledRulesMap {
 			ruleResult := []DisabledInterval{}
-			for i := 0; i < len(disabledArr); i++ {
+			for i := range disabledArr {
 				interval := DisabledInterval{
 					RuleName: ruleName,
 					From: token.Position{

rule/if_return.go

@@ -38,7 +38,7 @@ type lintElseError struct {
 func (w *lintElseError) Visit(node ast.Node) ast.Visitor {
 	switch v := node.(type) {
 	case *ast.BlockStmt:
-		for i := 0; i < len(v.List)-1; i++ {
+		for i := range len(v.List) - 1 {
 			// if var := whatever; var != nil { return var }
 			s, ok := v.List[i].(*ast.IfStmt)
 			if !ok || s.Body == nil || len(s.Body.List) != 1 || s.Else != nil {

rule/struct_tag.go

@@ -3,6 +3,7 @@ package rule
 import (
 	"fmt"
 	"go/ast"
+	"slices"
 	"strconv"
 	"strings"
 
@@ -574,12 +575,7 @@ func (w lintStructTagRule) isUserDefined(key, opt string) bool {
 	}
 
 	options := w.userDefined[key]
-	for _, o := range options {
-		if opt == o {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(options, opt)
 }
 
 func areValidateOpts(opts string) (string, bool) {

rule/unhandled_error.go

@@ -151,7 +151,7 @@ func (*lintUnhandledErrors) isTypeError(t *types.Named) bool {
 }
 
 func (w *lintUnhandledErrors) returnsAnError(tt *types.Tuple) bool {
-	for i := 0; i < tt.Len(); i++ {
+	for i := range tt.Len() {
 		nt, ok := tt.At(i).Type().(*types.Named)
 		if ok && w.isTypeError(nt) {
 			return true