fix: parameter -> property

Author: mgechev

README.md

@@ -31,9 +31,8 @@ Below you can find a recommended configuration which is based on the [Angular 2
   "component-selector-type": [true, "element"],
   "directive-selector-prefix": [true, "sg"],
   "component-selector-prefix": [true, "sg"],
-  "use-host-parameter-decorator": true,
-  "use-input-parameter-decorator": true,
-  "use-output-parameter-decorator": true,
+  "use-input-property-decorator": true,
+  "use-output-property-decorator": true,
   "no-attribute-parameter-decorator": true,
   "no-input-rename": true,
   "no-output-rename": true,

src/parameterDecoratorBase.ts renamed to src/propertyDecoratorBase.ts

@@ -4,17 +4,17 @@ import {sprintf} from 'sprintf-js';
 
 import SyntaxKind = require('./util/syntaxKind');
 
-export interface IUseParameterDecoratorConfig {
+export interface IUsePropertyDecoratorConfig {
   propertyName: string;
   decoratorName: string | string[];
   errorMessage: string;
 }
 
-export class UseParameterDecorator extends Lint.Rules.AbstractRule {
+export class UsePropertyDecorator extends Lint.Rules.AbstractRule {
   private static FAILURE_STRING = 'In the "@%s" class decorator of the class "%s"' +
   ' you are using the "%s" property, this is considered bad practice. Use %s property decorator instead.';
 
-  public static formatFailureString(config: IUseParameterDecoratorConfig, decoratorName: string, className: string) {
+  public static formatFailureString(config: IUsePropertyDecoratorConfig, decoratorName: string, className: string) {
     let decorators = config.decoratorName;
     if (decorators instanceof Array) {
       decorators = (<string[]>decorators).map(d => `"@${d}"`).join(', ');
@@ -24,9 +24,9 @@ export class UseParameterDecorator extends Lint.Rules.AbstractRule {
     return sprintf(config.errorMessage, decoratorName, className, config.propertyName, decorators);
   }
 
-  constructor(private config: IUseParameterDecoratorConfig, ruleName: string, value: any, disabledIntervals: Lint.IDisabledInterval[]) {
+  constructor(private config: IUsePropertyDecoratorConfig, ruleName: string, value: any, disabledIntervals: Lint.IDisabledInterval[]) {
     super(ruleName, value, disabledIntervals);
-    config.errorMessage = config.errorMessage || UseParameterDecorator.FAILURE_STRING;
+    config.errorMessage = config.errorMessage || UsePropertyDecorator.FAILURE_STRING;
   }
 
   public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] {
@@ -44,7 +44,7 @@ class DirectiveMetadataWalker extends Lint.RuleWalker {
   private typeChecker : ts.TypeChecker;
 
   constructor(sourceFile: ts.SourceFile, options: Lint.IOptions,
-    languageService : ts.LanguageService, private config: IUseParameterDecoratorConfig) {
+    languageService : ts.LanguageService, private config: IUsePropertyDecoratorConfig) {
       super(sourceFile, options);
       this.languageService = languageService;
       this.typeChecker = languageService.getProgram().getTypeChecker();
@@ -75,7 +75,7 @@ class DirectiveMetadataWalker extends Lint.RuleWalker {
           this.createFailure(
             p.getStart(),
             p.getWidth(),
-            UseParameterDecorator.formatFailureString(this.config, decoratorName, className)));
+            UsePropertyDecorator.formatFailureString(this.config, decoratorName, className)));
       });
     }
   }

src/useHostParameterDecoratorRule.ts renamed to src/useHostPropertyDecoratorRule.ts

@@ -1,8 +1,8 @@
 import * as Lint from 'tslint/lib/lint';
 
-import {UseParameterDecorator} from './parameterDecoratorBase';
+import {UsePropertyDecorator} from './propertyDecoratorBase';
 
-export class Rule extends UseParameterDecorator {
+export class Rule extends UsePropertyDecorator {
   constructor(ruleName: string, value: any, disabledIntervals: Lint.IDisabledInterval[]) {
     super({
       decoratorName: ['HostBindings', 'HostListeners'],

src/useInputParameterDecoratorRule.ts renamed to src/useInputPropertyDecoratorRule.ts

@@ -1,8 +1,8 @@
 import * as Lint from 'tslint/lib/lint';
 
-import {UseParameterDecorator} from './parameterDecoratorBase';
+import {UsePropertyDecorator} from './propertyDecoratorBase';
 
-export class Rule extends UseParameterDecorator {
+export class Rule extends UsePropertyDecorator {
   constructor(ruleName: string, value: any, disabledIntervals: Lint.IDisabledInterval[]) {
     super({
       decoratorName: 'Input',

src/useOutputParameterDecoratorRule.ts renamed to src/useOutputPropertyDecoratorRule.ts

@@ -1,8 +1,8 @@
 import * as Lint from 'tslint/lib/lint';
 
-import {UseParameterDecorator} from './parameterDecoratorBase';
+import {UsePropertyDecorator} from './propertyDecoratorBase';
 
-export class Rule extends UseParameterDecorator {
+export class Rule extends UsePropertyDecorator {
   constructor(ruleName: string, value: any, disabledIntervals: Lint.IDisabledInterval[]) {
     super({
       decoratorName: 'Output',

test/useHostParameterDecoratorRule.spec.ts renamed to test/useHostPropertyDecoratorRule.spec.ts

@@ -1,6 +1,6 @@
 import {assertFailure, assertSuccess} from './testHelper';
 
-describe('use-host-parameter-decorator', () => {
+describe('use-host-property-decorator', () => {
   it('should fail when "host" is used in @Component', () => {
     let source = `
       @Component({
@@ -10,7 +10,7 @@ describe('use-host-parameter-decorator', () => {
       })
       class Bar {}
     `;
-    assertFailure('use-host-parameter-decorator', source, {
+    assertFailure('use-host-property-decorator', source, {
       message: 'In the "@Component" class decorator of the class "Bar" you are using the "host" property, this is considered bad practice. Use "@HostBindings", "@HostListeners" property decorator instead.',
       startPosition: {
         line: 2,
@@ -29,7 +29,7 @@ describe('use-host-parameter-decorator', () => {
       })
       class Bar {}
     `;
-    assertSuccess('use-host-parameter-decorator', source);
+    assertSuccess('use-host-property-decorator', source);
   });
   it('should fail when "host" is used in @Directive', () => {
     let source = `
@@ -40,7 +40,7 @@ describe('use-host-parameter-decorator', () => {
       })
       class Baz {}
     `;
-    assertFailure('use-host-parameter-decorator', source, {
+    assertFailure('use-host-property-decorator', source, {
       message: 'In the "@Directive" class decorator of the class "Baz" you are using the "host" property, this is considered bad practice. Use "@HostBindings", "@HostListeners" property decorator instead.',
       startPosition: {
         line: 2,

test/useInputParameterDecoratorRule.spec.ts renamed to test/useInputPropertyDecoratorRule.spec.ts

@@ -1,6 +1,6 @@
 import {assertFailure, assertSuccess} from './testHelper';
 
-describe('use-input-parameter-decorator', () => {
+describe('use-input-property-decorator', () => {
   it('should fail when "inputs" is used in @Component', () => {
     let source = `
       @Component({
@@ -10,7 +10,7 @@ describe('use-input-parameter-decorator', () => {
       })
       class Bar {}
     `;
-    assertFailure('use-input-parameter-decorator', source, {
+    assertFailure('use-input-property-decorator', source, {
       message: 'In the "@Component" class decorator of the class "Bar" you are using the "inputs" property, this is considered bad practice. Use "@Input" property decorator instead.',
       startPosition: {
         line: 2,
@@ -29,7 +29,7 @@ describe('use-input-parameter-decorator', () => {
       })
       class Bar {}
     `;
-    assertSuccess('use-input-parameter-decorator', source);
+    assertSuccess('use-input-property-decorator', source);
   });
   it('should fail when "inputs" is used in @Directive', () => {
     let source = `
@@ -40,7 +40,7 @@ describe('use-input-parameter-decorator', () => {
       })
       class Baz {}
     `;
-    assertFailure('use-input-parameter-decorator', source, {
+    assertFailure('use-input-property-decorator', source, {
       message: 'In the "@Directive" class decorator of the class "Baz" you are using the "inputs" property, this is considered bad practice. Use "@Input" property decorator instead.',
       startPosition: {
         line: 2,

test/useOutputParameterDecoratorRule.spec.ts renamed to test/useOutputPropertyDecoratorRule.spec.ts

@@ -1,6 +1,6 @@
 import {assertFailure, assertSuccess} from './testHelper';
 
-describe('use-output-parameter-decorator', () => {
+describe('use-output-property-decorator', () => {
   it('should fail when "outputs" is used in @Component', () => {
     let source = `
       @Component({
@@ -10,7 +10,7 @@ describe('use-output-parameter-decorator', () => {
       })
       class Bar {}
     `;
-    assertFailure('use-output-parameter-decorator', source, {
+    assertFailure('use-output-property-decorator', source, {
       message: 'In the "@Component" class decorator of the class "Bar" you are using the "outputs" property, this is considered bad practice. Use "@Output" property decorator instead.',
       startPosition: {
         line: 2,
@@ -29,7 +29,7 @@ describe('use-output-parameter-decorator', () => {
       })
       class Bar {}
     `;
-    assertSuccess('use-output-parameter-decorator', source);
+    assertSuccess('use-output-property-decorator', source);
   });
   it('should fail when "outputs" is used in @Directive', () => {
     let source = `
@@ -40,7 +40,7 @@ describe('use-output-parameter-decorator', () => {
       })
       class Baz {}
     `;
-    assertFailure('use-output-parameter-decorator', source, {
+    assertFailure('use-output-property-decorator', source, {
       message: 'In the "@Directive" class decorator of the class "Baz" you are using the "outputs" property, this is considered bad practice. Use "@Output" property decorator instead.',
       startPosition: {
         line: 2,