Skip to content

Commit af8d793

Browse files
authored
unify short name for mysqlConn in connection_test (go-sql-driver#1581)
1 parent 7939f59 commit af8d793

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

connection_test.go

+6-6
Original file line numberDiff line numberDiff line change
@@ -117,8 +117,8 @@ func TestInterpolateParamsUint64(t *testing.T) {
117117

118118
func TestCheckNamedValue(t *testing.T) {
119119
value := driver.NamedValue{Value: ^uint64(0)}
120-
x := &mysqlConn{}
121-
err := x.CheckNamedValue(&value)
120+
mc := &mysqlConn{}
121+
err := mc.CheckNamedValue(&value)
122122

123123
if err != nil {
124124
t.Fatal("uint64 high-bit not convertible", err)
@@ -159,13 +159,13 @@ func TestCleanCancel(t *testing.T) {
159159

160160
func TestPingMarkBadConnection(t *testing.T) {
161161
nc := badConnection{err: errors.New("boom")}
162-
ms := &mysqlConn{
162+
mc := &mysqlConn{
163163
netConn: nc,
164164
buf: newBuffer(nc),
165165
maxAllowedPacket: defaultMaxAllowedPacket,
166166
}
167167

168-
err := ms.Ping(context.Background())
168+
err := mc.Ping(context.Background())
169169

170170
if err != driver.ErrBadConn {
171171
t.Errorf("expected driver.ErrBadConn, got %#v", err)
@@ -174,15 +174,15 @@ func TestPingMarkBadConnection(t *testing.T) {
174174

175175
func TestPingErrInvalidConn(t *testing.T) {
176176
nc := badConnection{err: errors.New("failed to write"), n: 10}
177-
ms := &mysqlConn{
177+
mc := &mysqlConn{
178178
netConn: nc,
179179
buf: newBuffer(nc),
180180
maxAllowedPacket: defaultMaxAllowedPacket,
181181
closech: make(chan struct{}),
182182
cfg: NewConfig(),
183183
}
184184

185-
err := ms.Ping(context.Background())
185+
err := mc.Ping(context.Background())
186186

187187
if err != ErrInvalidConn {
188188
t.Errorf("expected ErrInvalidConn, got %#v", err)

0 commit comments

Comments
 (0)