return ResourceExhausted if provisioner pod fails (#10)

* return ResourceExhausted if provisioner pod fails

* return ResourceExhausted so the requesting pod can be rescheduled to anonther node
* update external csi driver images
* allow underscore in branch names

Author: mwennrich

Makefile

@@ -1,5 +1,5 @@
 GO111MODULE := on
-DOCKER_TAG := $(or ${GITHUB_TAG_NAME}, latest)
+DOCKER_TAG := $(or $(subst _,-,$(GITHUB_TAG_NAME)), latest)
 
 all: provisioner lvmplugin
 

helm/csi-driver-lvm/templates/csi-lvm-attacher.yaml

@@ -45,7 +45,7 @@ spec:
       serviceAccountName: csi-attacher
       containers:
         - name: csi-attacher
-          image: quay.io/k8scsi/csi-attacher:v2.1.0
+          image: quay.io/k8scsi/csi-attacher:v2.2.0
           args:
             - --v=5
             - --csi-address=/csi/csi.sock

helm/csi-driver-lvm/templates/csi-lvm-plugin-deployment.yaml

@@ -40,7 +40,7 @@ spec:
             fieldRef:
               apiVersion: v1
               fieldPath: spec.nodeName
-        image: quay.io/k8scsi/csi-node-driver-registrar:v1.2.0
+        image: quay.io/k8scsi/csi-node-driver-registrar:v1.3.0
         imagePullPolicy: IfNotPresent
         lifecycle:
           preStop:

helm/csi-driver-lvm/templates/csi-lvm-provisioner.yaml

@@ -45,7 +45,7 @@ spec:
       serviceAccountName: csi-provisioner
       containers:
         - name: csi-provisioner
-          image: quay.io/k8scsi/csi-provisioner:v1.5.0
+          image: quay.io/k8scsi/csi-provisioner:v1.6.0
           args:
             - -v=5
             - --csi-address=/csi/csi.sock

helm/csi-driver-lvm/templates/csi-lvm-resizer.yaml

@@ -45,7 +45,7 @@ spec:
       serviceAccountName: csi-resizer
       containers:
         - name: csi-resizer
-          image: quay.io/k8scsi/csi-resizer:v0.4.0
+          image: quay.io/k8scsi/csi-resizer:v0.5.0
           args:
             - -v=5
             - -csi-address=/csi/csi.sock

pkg/lvm/lvm.go

@@ -27,6 +27,8 @@ import (
 	"time"
 
 	"github.com/google/lvmd/commands"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
 
 	v1 "k8s.io/api/core/v1"
 	k8serror "k8s.io/apimachinery/pkg/api/errors"
@@ -389,6 +391,13 @@ func createProvisionerPod(va volumeAction) (err error) {
 	retrySeconds := 60
 	for i := 0; i < retrySeconds; i++ {
 		pod, err := va.kubeClient.CoreV1().Pods(va.namespace).Get(provisionerPod.Name, metav1.GetOptions{})
+		if pod.Status.Phase == v1.PodFailed {
+			// pod terminated in time, but with failure
+			// return ResourceExhausted so the requesting pod can be rescheduled to anonther node
+			// see https://github.com/kubernetes-csi/external-provisioner/pull/405
+			klog.Info("provisioner pod terminated with failure")
+			return status.Error(codes.ResourceExhausted, "volume creation failed")
+		}
 		if err != nil {
 			klog.Errorf("error reading provisioner pod:%v", err)
 		} else if pod.Status.Phase == v1.PodSucceeded {

tests/files/helm/csi-driver-lvm/templates/csi-lvm-attacher.yaml

@@ -45,7 +45,7 @@ spec:
       serviceAccountName: csi-attacher
       containers:
         - name: csi-attacher
-          image: quay.io/k8scsi/csi-attacher:v2.1.0
+          image: quay.io/k8scsi/csi-attacher:v2.2.0
           args:
             - --v=5
             - --csi-address=/csi/csi.sock

tests/files/helm/csi-driver-lvm/templates/csi-lvm-plugin-deployment.yaml

@@ -40,7 +40,7 @@ spec:
             fieldRef:
               apiVersion: v1
               fieldPath: spec.nodeName
-        image: quay.io/k8scsi/csi-node-driver-registrar:v1.2.0
+        image: quay.io/k8scsi/csi-node-driver-registrar:v1.3.0
         imagePullPolicy: IfNotPresent
         lifecycle:
           preStop:

tests/files/helm/csi-driver-lvm/templates/csi-lvm-provisioner.yaml

@@ -45,7 +45,7 @@ spec:
       serviceAccountName: csi-provisioner
       containers:
         - name: csi-provisioner
-          image: quay.io/k8scsi/csi-provisioner:v1.5.0
+          image: quay.io/k8scsi/csi-provisioner:v1.6.0
           args:
             - -v=5
             - --csi-address=/csi/csi.sock

tests/files/helm/csi-driver-lvm/templates/csi-lvm-resizer.yaml

@@ -45,7 +45,7 @@ spec:
       serviceAccountName: csi-resizer
       containers:
         - name: csi-resizer
-          image: quay.io/k8scsi/csi-resizer:v0.4.0
+          image: quay.io/k8scsi/csi-resizer:v0.5.0
           args:
             - -v=5
             - -csi-address=/csi/csi.sock