remove unnecessary checks for MetricMap

Author: Meshwa Savalia

aws_embedded_metrics/logger/metrics_context.py

@@ -58,8 +58,7 @@ def put_metric(self, key: str, value: float, unit: str = None, storageResolution
             metric.add_value(value)
         else:
             self.metrics[key] = Metric(value, unit, storageResolution)
-        if key not in self.metricNameAndResolutionMap:
-            self.metricNameAndResolutionMap[key] = storageResolution
+        self.metricNameAndResolutionMap[key] = storageResolution
 
     def put_dimensions(self, dimension_set: Dict[str, str]) -> None:
         """

aws_embedded_metrics/validator.py

@@ -87,7 +87,7 @@ def validate_metric(name: str, value: float, unit: Optional[str], storageResolut
     if storageResolution is None or storageResolution not in StorageResolution:
         raise InvalidMetricError(f"Metric storage Resolution is not valid: {storageResolution}")
 
-    if metricNameAndResolutionMap and name in metricNameAndResolutionMap and metricNameAndResolutionMap.get(name) is not storageResolution:
+    if name in metricNameAndResolutionMap and metricNameAndResolutionMap.get(name) is not storageResolution:
         raise InvalidMetricError(
             "Resolution for metrics ${name} is already set. A single log event cannot have a metric with two different resolutions.")
 

tests/logger/test_metrics_context.py

@@ -318,6 +318,7 @@ def test_put_metric_uses_standard_storage_resolution_if_not_provided():
         ("metric", math.nan, "Seconds", StorageResolution.STANDARD),
         ("metric", 1, "Kilometers/Fahrenheit", StorageResolution.STANDARD),
         ("metric", 1, "Seconds", 2),
+        ("metric", 1, "Seconds", 0),
         ("metric", 1, "Seconds", None)
     ]
 )