This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Fix issue #3522 (WiFi does not restart after stopped) (#4114) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssif#4114) This commit fixes issue espressif#3522 where WiFi service fails to start after a WiFi.disconnect(true) or a WiFi.mode(WIFI_OFF).
|
I flashed this to my TBeam, and it does appear to fix the WiFi coming back from after sleeping, but it exposes an issue where the HTTP server does not come back from after sleeping Screenshot shows device progressing from:
I tried refreshing the browser too (thinking that maybe my web app isn't handling the reconnect gracefully (meshtastic/web#3), but refreshing the browser just gave a timeout, so I think the HTTP server just isn't coming back. @mc-hamster maybe you can figure that one out.
|
|
This pull request has been mentioned on Meshtastic. There might be relevant details there: https://meshtastic.discourse.group/t/a-favor-requested-from-someone-running-windows/1957/3 |
geeksville
approved these changes
Dec 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming we don't want to simply update to the latest commit from the espressif upstream library, this cherry-picks in the fix from espressif#4114
I have not yet tested this
This commit fixes issue espressif#3522 where WiFi service fails to start after a WiFi.disconnect(true) or a WiFi.mode(WIFI_OFF).