Merge pull request swiftlang#2517 from mustiikhalil/fix-source-edit-length-value

ahoppen · web-flow · commit ecbd7df6608a · 2024-03-01T13:55:37.000-08:00
(fix): Bug where length return is negative
diff --git a/Sources/SwiftSyntax/SourceEdit.swift b/Sources/SwiftSyntax/SourceEdit.swift
@@ -21,7 +21,7 @@ public struct SourceEdit: Equatable, Sendable {
   /// Length of the original source range that this edit applies to. Zero if
   /// this is an addition.
   public var length: SourceLength {
-    return SourceLength(utf8Length: range.lowerBound.utf8Offset - range.upperBound.utf8Offset)
+    return SourceLength(utf8Length: range.upperBound.utf8Offset - range.lowerBound.utf8Offset)
   }
 
   /// Create an edit to replace `range` in the original source with

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public struct SourceEdit: Equatable, Sendable {`
`21`	`21`	`/// Length of the original source range that this edit applies to. Zero if`
`22`	`22`	`/// this is an addition.`
`23`	`23`	`public var length: SourceLength {`
`24`		`- return SourceLength(utf8Length: range.lowerBound.utf8Offset - range.upperBound.utf8Offset)`
	`24`	`+ return SourceLength(utf8Length: range.upperBound.utf8Offset - range.lowerBound.utf8Offset)`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	/// Create an edit to replace `range` in the original source with