Optimize SSL/X509 state machines for size

The state machine implementations are the largest bits of the SSL
engine, but they're also not performance sensitive like the encryption
code.  Optimize the FSMs for size, leaving everything else as -O2.

Author: earlephilhower

src/ssl/ssl_hs_client.c

@@ -395,6 +395,9 @@ make_client_sign(br_ssl_client_context *ctx)
 		ctx->eng.pad, sizeof ctx->eng.pad);
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 
 
 static const unsigned char t0_datablock[] PROGMEM = {

src/ssl/ssl_hs_client.t0

@@ -339,6 +339,9 @@ make_client_sign(br_ssl_client_context *ctx)
 		ctx->eng.pad, sizeof ctx->eng.pad);
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 }
 
 \ =======================================================================

src/ssl/ssl_hs_server.c

@@ -426,6 +426,9 @@ verify_CV_sig(br_ssl_server_context *ctx, size_t sig_len)
 	return 0;
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 
 
 static const unsigned char t0_datablock[] PROGMEM = {

src/ssl/ssl_hs_server.t0

@@ -370,6 +370,9 @@ verify_CV_sig(br_ssl_server_context *ctx, size_t sig_len)
 	return 0;
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 }
 
 \ =======================================================================

src/x509/pkey_decoder.c

@@ -100,6 +100,9 @@ br_pkey_decoder_push(br_pkey_decoder_context *ctx,
 	br_pkey_decoder_run(&ctx->cpu);
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 
 
 static const unsigned char t0_datablock[] PROGMEM = {

src/x509/pkey_decoder.t0

@@ -48,6 +48,9 @@ br_pkey_decoder_push(br_pkey_decoder_context *ctx,
 	br_pkey_decoder_run(&ctx->cpu);
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 }
 
 addr: key_type

src/x509/skey_decoder.c

@@ -100,6 +100,9 @@ br_skey_decoder_push(br_skey_decoder_context *ctx,
 	br_skey_decoder_run(&ctx->cpu);
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 
 
 static const unsigned char t0_datablock[] PROGMEM = {

src/x509/skey_decoder.t0

@@ -48,6 +48,9 @@ br_skey_decoder_push(br_skey_decoder_context *ctx,
 	br_skey_decoder_run(&ctx->cpu);
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 }
 
 addr: key_type

src/x509/x509_decoder.c

@@ -113,6 +113,9 @@ br_x509_decoder_push(br_x509_decoder_context *ctx,
 	br_x509_decoder_run(&ctx->cpu);
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 
 
 static const unsigned char t0_datablock[] PROGMEM = {

src/x509/x509_decoder.t0

@@ -61,6 +61,9 @@ br_x509_decoder_push(br_x509_decoder_context *ctx,
 	br_x509_decoder_run(&ctx->cpu);
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
+
 }
 
 addr: decoded

src/x509/x509_minimal.c

@@ -158,7 +158,7 @@ void br_x509_minimal_run(void *t0ctx);
  *     -- Extensions: extension values are processed in due order.
  *
  *        -- Basic Constraints: for all certificates except EE, must be
- *        present, indicate a CA, and have a path legnth compatible with
+ *        present, indicate a CA, and have a path length compatible with
  *        the chain length so far.
  *
  *        -- Key Usage: for the EE, if present, must allow signatures
@@ -489,6 +489,8 @@ static int check_single_trust_anchor_CA(br_x509_minimal_context *ctx,
         return 0;
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
 
 
 

src/x509/x509_minimal.t0

@@ -437,6 +437,8 @@ static int check_single_trust_anchor_CA(br_x509_minimal_context *ctx,
         return 0;
 }
 
+/* State machine should be squeezed for size, not performance critical */
+#pragma GCC optimize ("Os")
 
 }