Depricated __add__ in favor of union

Author: benthayer

doc/source/whatsnew/v0.20.0.txt

@@ -486,7 +486,7 @@ Deprecations
 - ``DataFrame.astype()`` has deprecated the ``raise_on_error`` parameter in favor of ``errors`` (:issue:`14878`)
 - ``Series.sortlevel`` and ``DataFrame.sortlevel`` have been deprecated in favor of ``Series.sort_index`` and ``DataFrame.sort_index`` (:issue:`15099`)
 - importing ``concat`` from ``pandas.tools.merge`` has been deprecated in favor of imports from the ``pandas`` namespace. This should only affect explict imports (:issue:`15358`)
-
+- ``FrozenList.__add__`` has been depricated in favor of ``FrozenList.union`` (:issue: `15506`)
 .. _whatsnew_0200.prior_deprecations:
 
 Removal of prior version deprecations/changes

pandas/indexes/frozen.py

@@ -13,6 +13,8 @@
 from pandas.types.cast import _coerce_indexer_dtype
 from pandas.formats.printing import pprint_thing
 
+import warnings
+
 
 class FrozenList(PandasObject, list):
 
@@ -25,6 +27,7 @@ class FrozenList(PandasObject, list):
     #           typechecks
 
     def __add__(self, other):
+        warnings.warn("__add__ is deprecated, use union(...)", FutureWarning)
         if isinstance(other, tuple):
             other = list(other)
         return self.__class__(super(FrozenList, self).__add__(other))
@@ -80,6 +83,11 @@ def __repr__(self):
     __setitem__ = __setslice__ = __delitem__ = __delslice__ = _disabled
     pop = append = extend = remove = sort = insert = _disabled
 
+    def union(self, other):
+        if isinstance(other, tuple):
+            other = list(other)
+        return self.__class__(super(FrozenList, self).__add__(other))
+
     def difference(self, other):
         other = set(other)
         temp = [x for x in self if x not in other]

pandas/tests/indexes/test_frozen.py

@@ -14,22 +14,11 @@ def setUp(self):
         self.container = FrozenList(self.lst)
         self.klass = FrozenList
 
-    def test_add(self):
-        result = self.container + (1, 2, 3)
+    def test_union(self):
+        result = self.container.union((1, 2, 3))
         expected = FrozenList(self.lst + [1, 2, 3])
         self.check_result(result, expected)
 
-        result = (1, 2, 3) + self.container
-        expected = FrozenList([1, 2, 3] + self.lst)
-        self.check_result(result, expected)
-
-    def test_inplace_add(self):
-        q = r = self.container
-        q += [5]
-        self.check_result(q, self.lst + [5])
-        # other shouldn't be mutated
-        self.check_result(r, self.lst)
-
     def test_difference(self):
         result = self.container.difference([2])
         expected = FrozenList([1, 3, 4, 5])