Skip to content

Commit 1d1cc33

Browse files
committed
Fix placeholder centering in roles page and skills page.
Fix role details popup changing size: topcoder-archive#309. Redirect to My Teams list page instead of specific team: topcoder-archive#309. Send previousRoleSearchRequestId in /sendRoleSearchRequest POST.
1 parent eead1c5 commit 1d1cc33

File tree

6 files changed

+27
-26
lines changed

6 files changed

+27
-26
lines changed

src/routes/CreateNewTeam/components/ItemList/styles.module.scss

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
margin-right: 20px;
88
position: relative;
99
height: 80vh;
10-
overflow-y: scroll;
10+
overflow-y: auto;
1111

1212
> header {
1313
padding: 16px 24px;
@@ -33,9 +33,9 @@ input:not([type="checkbox"]).filter-input {
3333
color: #2a2a2a;
3434
font-size: 14px;
3535
height: 40px;
36-
line-height: 38px;
36+
line-height: normal;
3737
outline: none;
38-
padding: 0 15px;
38+
padding: 8px 15px;
3939

4040
&:not(:focus) {
4141
background-image: url("../../../../assets/images/icon-search.svg");

src/routes/CreateNewTeam/components/RoleDetailsModal/index.jsx

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -90,19 +90,21 @@ function RoleDetailsModal({ roleId, open, onClose }) {
9090
Skills
9191
</Button>
9292
</div>
93-
{showSkills ? (
94-
<ul styleName="body skill-list">
95-
{skills.map((skill, i) => (
96-
<li styleName="skill-item" key={i}>
97-
{skill}
98-
</li>
99-
))}
100-
</ul>
101-
) : (
102-
<div styleName="markdown-container">
103-
<MarkdownViewer value={role?.description} />
104-
</div>
105-
)}
93+
<div styleName="content">
94+
{showSkills ? (
95+
<ul styleName="body skill-list">
96+
{skills.map((skill, i) => (
97+
<li styleName="skill-item" key={i}>
98+
{skill}
99+
</li>
100+
))}
101+
</ul>
102+
) : (
103+
<div styleName="markdown-container">
104+
<MarkdownViewer value={role?.description} />
105+
</div>
106+
)}
107+
</div>
106108
</div>
107109
</BaseCreateModal>
108110
);

src/routes/CreateNewTeam/components/RoleDetailsModal/styles.module.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,3 +58,8 @@
5858
margin-bottom: 10px;
5959
font-size: 12px;
6060
}
61+
62+
.content {
63+
height: 180px;
64+
overflow-y: auto;
65+
}

src/routes/CreateNewTeam/components/SubmitContainer/index.jsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,10 +94,9 @@ function SubmitContainer({
9494
const requestTeam = useCallback(() => {
9595
setRequestLoading(true);
9696
postTeamRequest(teamObject)
97-
.then((res) => {
98-
const projectId = _.get(res, ["data", "projectId"]);
97+
.then(() => {
9998
dispatch(clearSearchedRoles());
100-
navigate(`/taas/myteams/${projectId}`);
99+
navigate("/taas/myteams");
101100
})
102101
.catch((err) => {
103102
setRequestLoading(false);

src/routes/CreateNewTeam/components/TeamDetailsModal/styles.module.scss

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,8 @@
8585
}
8686

8787
.modal-body {
88+
overflow-x: auto;
8889
textarea {
8990
height: 95px;
9091
}
9192
}
92-
93-
@media only screen and (max-width: 550px) {
94-
.modal-body {
95-
overflow-x: scroll;
96-
}
97-
}

src/services/teams.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,13 +215,13 @@ export const postProject = () => {
215215
* @param {string} searchObject.roleId a role id to search for
216216
* @param {string} searchObject.jobDescription job description used for search
217217
* @param {string[]} searchObject.skills array of skill ids used for role search
218+
* @param {string} searchObject.jobTitle job title to associate with search
218219
* @param {string} searchObject.previousRoleSearchRequestId id of the last search made
219220
*
220221
* @returns {Promise<object>} the role found
221222
*/
222223
export const searchRoles = (searchObject) => {
223224
const newObject = { ...searchObject };
224-
delete newObject.previousRoleSearchRequestId;
225225
const url = `${config.API.V5}/taas-teams/sendRoleSearchRequest`;
226226
return axios.post(url, newObject);
227227
};

0 commit comments

Comments
 (0)