Skip to content

Commit 47ce2f4

Browse files
authored
Merge pull request kubernetes-sigs#46 from shaneutt/defaults-in-namespace
provide more defaults in Makefile
2 parents dfdcc0b + 073c86d commit 47ce2f4

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

Makefile

+8-14
Original file line numberDiff line numberDiff line change
@@ -645,9 +645,11 @@ check-alias: check-container-tool
645645
echo "✅ Alias is likely to work: alias $(PROJECT_NAME)='$(CONTAINER_TOOL) exec -it $(PROJECT_NAME)-container /app/$(PROJECT_NAME)'"; \
646646
fi
647647

648+
# This is being used for tekton builds in the CI/CD pipeline, to provide a
649+
# default namespace to do a test deployment of the Kubernetes dev environment.
648650
.PHONY: print-namespace
649-
print-namespace: ## Print the current namespace
650-
@echo "$(NAMESPACE)"
651+
print-namespace:
652+
@echo "inference-router"
651653

652654
.PHONY: print-project-name
653655
print-project-name: ## Print the current project name
@@ -752,6 +754,10 @@ endif
752754
# This target deploys the GIE stack in a specific namespace for development and
753755
# testing.
754756
# ------------------------------------------------------------------------------
757+
VLLM_SIM_IMAGE ?= quay.io/vllm-d/vllm-sim
758+
VLLM_SIM_TAG ?= 0.0.2
759+
EPP_IMAGE ?= us-central1-docker.pkg.dev/k8s-staging-images/gateway-api-inference-extension/epp
760+
EPP_TAG ?= main
755761
.PHONY: environment.dev.kubernetes
756762
environment.dev.kubernetes: check-kubectl check-kustomize check-envsubst
757763
@echo "INFO: checking required vars"
@@ -763,21 +769,9 @@ ifndef REGISTRY_SECRET
763769
$(error "Error: REGISTRY_SECRET is required but not set)
764770
endif
765771
export REGISTRY_SECRET=${REGISTRY_SECRET}
766-
ifndef VLLM_SIM_IMAGE
767-
$(error "Error: VLLM_SIM_IMAGE is required but not set)
768-
endif
769772
export VLLM_SIM_IMAGE=${VLLM_SIM_IMAGE}
770-
ifndef VLLM_SIM_TAG
771-
$(error "Error: VLLM_SIM_TAG is required but not set)
772-
endif
773773
export VLLM_SIM_TAG=${VLLM_SIM_TAG}
774-
ifndef EPP_IMAGE
775-
$(error "Error: EPP_IMAGE is required but not set)
776-
endif
777774
export EPP_IMAGE=${EPP_IMAGE}
778-
ifndef EPP_TAG
779-
$(error "Error: EPP_TAG is required but not set)
780-
endif
781775
export EPP_TAG=${EPP_TAG}
782776
@echo "INFO: Creating namespace (if needed) and setting context to $(NAMESPACE)..."
783777
kubectl create namespace $(NAMESPACE) 2>/dev/null || true

0 commit comments

Comments
 (0)