Skip to content

Commit f9ee9cd

Browse files
author
mattgreen
committed
Removes socket.io-client reference from index.html
Adds socket-io-client to bower Fixes issue with gulp wiredep removing the string 'client' from added packages with the word 'client' in it's name Closes angular-fullstack#2524
1 parent a54c8cb commit f9ee9cd

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

Diff for: templates/app/_bower.json

+1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"angular-bootstrap": "~1.1.2",<% } %>
1616
"font-awesome": ">=4.1.0",
1717
"lodash": "~2.4.1"<% if(filters.socketio) { %>,
18+
"socket-io-client": "^1.4.5",
1819
"angular-socket-io": "~0.7.0"<% } if (filters.uirouter) { %>,
1920
"angular-ui-router": "~0.2.15"<% } if (filters.auth) { %>,
2021
"angular-validation-match": "~1.5.2"<% } %>

Diff for: templates/app/client/index.html

+1-2
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@
4848
<![endif]-->
4949
<!-- build:js({client,node_modules}) app/vendor.js -->
5050
<!-- bower:js -->
51-
<!-- endbower --><% if (filters.socketio) { %>
52-
<script src="socket.io-client/socket.io.js"></script><% } %>
51+
<!-- endbower -->
5352
<!-- endbuild -->
5453
<!-- build:js(<% if(filters.babel) { %>.tmp<% }
5554
else { %>{.tmp,client}<% } %>) app/app.js -->

Diff for: templates/app/gulpfile.babel(gulp).js

+1-1
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ gulp.task('wiredep:client', () => {
523523
/bootstrap-sass-official/<% } if(filters.oauth) { %>,
524524
/bootstrap-social\.css/<% }}} %>
525525
],
526-
ignorePath: clientPath
526+
ignorePath: './' + clientPath
527527
}))
528528
.pipe(gulp.dest(`${clientPath}/`));
529529
});

0 commit comments

Comments
 (0)