Skip to content

Commit 8a817bc

Browse files
ehussjyn514
authored andcommitted
Update for review comments.
1 parent aaf6ccc commit 8a817bc

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

src/tests/adding.md

+9-4
Original file line numberDiff line numberDiff line change
@@ -232,10 +232,10 @@ source.
232232
possible (unless on a platform that does not support them, or
233233
`no-prefer-dynamic` is specified in the aux file). The `-L` flag is used to
234234
find the extern crates.
235-
* `aux-crate` is very similar to `aux-build`, however it uses the `--extern`
235+
* `aux-crate` is very similar to `aux-build`; however, it uses the `--extern`
236236
flag to link to the extern crate. That allows you to specify the additional
237237
syntax of the `--extern` flag, such as renaming a dependency. For example,
238-
`// aux-crate:foo=bar.rs` will compile `auxiliary/bar.rs` and add make it
238+
`// aux-crate:foo=bar.rs` will compile `auxiliary/bar.rs` and make it
239239
available under then name `foo` within the test. This is similar to how
240240
Cargo does dependency renaming.
241241
* `no-prefer-dynamic` will force an auxiliary crate to be built as an rlib
@@ -257,11 +257,16 @@ source.
257257
`-Zunpretty=expanded` as a final step. It will also try to compile the
258258
resulting output (without codegen). This is needed because not all code can
259259
be compiled after being expanded. Pretty tests should specify this if they
260-
can. More history about this may be found in [#23616].
260+
can. An example where this cannot be used is if the test includes
261+
`println!`. That macro expands to reference private internal functions of
262+
the standard library that cannot be called directly without the
263+
`fmt_internals` feature gate.
264+
265+
More history about this may be found in [#23616].
261266
* `pp-exact` is used to ensure a pretty-print test results in specific output.
262267
If specified without a value, then it means the pretty-print output should
263268
match the original source. If specified with a value, as in `//
264-
pp-exact:foo.pp`, will ensure that that pretty-printed output matches the
269+
pp-exact:foo.pp`, it will ensure that the pretty-printed output matches the
265270
contents of the given file. Otherwise, if `pp-exact` is not specified, then
266271
the pretty-printed output will be pretty-printed one more time, and the
267272
output of the two pretty-printing rounds will be compared to ensure that the

0 commit comments

Comments
 (0)