Skip to content

Commit 5caa7f9

Browse files
committed
Improve html-checker error message
The previous message omits which of the dozens of tools called tidy is meant. And it's written in a way that one can easily miss the *not*, thinking it reads "Note that `tidy` is the in-tree `src/tools/tidy` but needs to be installed". The error message should hopefully help future contributors.
1 parent b7deff3 commit 5caa7f9

File tree

1 file changed

+1
-1
lines changed
  • src/bootstrap/src/core/build_steps

1 file changed

+1
-1
lines changed

src/bootstrap/src/core/build_steps/test.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ impl Step for HtmlCheck {
201201
if !check_if_tidy_is_installed() {
202202
eprintln!("not running HTML-check tool because `tidy` is missing");
203203
eprintln!(
204-
"Note that `tidy` is not the in-tree `src/tools/tidy` but needs to be installed"
204+
"You need the HTML tidy tool https://www.html-tidy.org/, this tool is *not* part of the rust project and needs to be installed separately, for example via your package manager."
205205
);
206206
panic!("Cannot run html-check tests");
207207
}

0 commit comments

Comments
 (0)