rustdoc: Don't put non rustdoc-reachable impls into all_trait_impls

petrochenkov · petrochenkov · commit 398225842cbf · 2023-01-25T23:39:29.000+04:00
diff --git a/src/librustdoc/passes/collect_intra_doc_links/early.rs b/src/librustdoc/passes/collect_intra_doc_links/early.rs
@@ -162,6 +162,7 @@ impl<'ra> EarlyDocLinkResolver<'_, 'ra> {
                         }
                         self.resolve_doc_links_extern_impl(impl_def_id, false);
                     }
+                    self.all_trait_impls.push(impl_def_id);
                 }
                 for (ty_def_id, impl_def_id) in all_inherent_impls {
                     if self.is_doc_reachable(ty_def_id) {
@@ -171,9 +172,6 @@ impl<'ra> EarlyDocLinkResolver<'_, 'ra> {
                 for impl_def_id in all_incoherent_impls {
                     self.resolve_doc_links_extern_impl(impl_def_id, true);
                 }
-
-                self.all_trait_impls
-                    .extend(all_trait_impls.into_iter().map(|(_, def_id, _)| def_id));
             }
 
             if crates.len() > start_cnum {

Original file line number	Diff line number	Diff line change
`@@ -162,6 +162,7 @@ impl<'ra> EarlyDocLinkResolver<'_, 'ra> {`
`162`	`162`	`}`
`163`	`163`	`self.resolve_doc_links_extern_impl(impl_def_id, false);`
`164`	`164`	`}`
	`165`	`+ self.all_trait_impls.push(impl_def_id);`
`165`	`166`	`}`
`166`	`167`	`for (ty_def_id, impl_def_id) in all_inherent_impls {`
`167`	`168`	`if self.is_doc_reachable(ty_def_id) {`
`@@ -171,9 +172,6 @@ impl<'ra> EarlyDocLinkResolver<'_, 'ra> {`
`171`	`172`	`for impl_def_id in all_incoherent_impls {`
`172`	`173`	`self.resolve_doc_links_extern_impl(impl_def_id, true);`
`173`	`174`	`}`
`174`		`-`
`175`		`- self.all_trait_impls`
`176`		`- .extend(all_trait_impls.into_iter().map(\|(_, def_id, _)\| def_id));`
`177`	`175`	`}`
`178`	`176`
`179`	`177`	`if crates.len() > start_cnum {`