Skip to content

Commit 120b841

Browse files
committed
Modified the tests so that if we place wrong parentheses we will get a different result
1 parent 66e212b commit 120b841

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

tests/ui/precedence.fixed

+4-4
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ fn main() {
2020
1 ^ (1 - 1);
2121
3 | (2 - 1);
2222
3 & (5 - 2);
23-
12 & (0xF000 << 4);
24-
12 & (0xF000 >> 4);
25-
(12 << 4) ^ 0xF000;
26-
(12 << 4) | 0xF000;
23+
0x0F00 & (0x00F0 << 4);
24+
0x0F00 & (0xF000 >> 4);
25+
(0x0F00 << 1) ^ 3;
26+
(0x0F00 << 1) | 2;
2727

2828
let b = 3;
2929
trip!(b * 8);

tests/ui/precedence.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ fn main() {
2020
1 ^ 1 - 1;
2121
3 | 2 - 1;
2222
3 & 5 - 2;
23-
12 & 0xF000 << 4;
24-
12 & 0xF000 >> 4;
25-
12 << 4 ^ 0xF000;
26-
12 << 4 | 0xF000;
23+
0x0F00 & 0x00F0 << 4;
24+
0x0F00 & 0xF000 >> 4;
25+
0x0F00 << 1 ^ 3;
26+
0x0F00 << 1 | 2;
2727

2828
let b = 3;
2929
trip!(b * 8);

tests/ui/precedence.stderr

+8-8
Original file line numberDiff line numberDiff line change
@@ -46,26 +46,26 @@ LL | 3 & 5 - 2;
4646
error: operator precedence can trip the unwary
4747
--> tests/ui/precedence.rs:23:5
4848
|
49-
LL | 12 & 0xF000 << 4;
50-
| ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `12 & (0xF000 << 4)`
49+
LL | 0x0F00 & 0x00F0 << 4;
50+
| ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `0x0F00 & (0x00F0 << 4)`
5151

5252
error: operator precedence can trip the unwary
5353
--> tests/ui/precedence.rs:24:5
5454
|
55-
LL | 12 & 0xF000 >> 4;
56-
| ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `12 & (0xF000 >> 4)`
55+
LL | 0x0F00 & 0xF000 >> 4;
56+
| ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `0x0F00 & (0xF000 >> 4)`
5757

5858
error: operator precedence can trip the unwary
5959
--> tests/ui/precedence.rs:25:5
6060
|
61-
LL | 12 << 4 ^ 0xF000;
62-
| ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(12 << 4) ^ 0xF000`
61+
LL | 0x0F00 << 1 ^ 3;
62+
| ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(0x0F00 << 1) ^ 3`
6363

6464
error: operator precedence can trip the unwary
6565
--> tests/ui/precedence.rs:26:5
6666
|
67-
LL | 12 << 4 | 0xF000;
68-
| ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(12 << 4) | 0xF000`
67+
LL | 0x0F00 << 1 | 2;
68+
| ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(0x0F00 << 1) | 2`
6969

7070
error: aborting due to 11 previous errors
7171

0 commit comments

Comments
 (0)