Skip to content

Commit f0bff09

Browse files
Merge pull request multi-build#262 from mattip/abi_tag
MRG: fixes to allow Python 3.8 RC installs Remove `m` from ABI tag. Look for RC when installing Python 3.8 from macOS download.
2 parents 1826f1f + 792ebe6 commit f0bff09

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

.travis.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,12 @@ matrix:
7878
- PYTHON_VERSION=3.7
7979
- VENV=venv
8080
- USE_CCACHE=1
81+
- os: osx
82+
env:
83+
- PYTHON_VERSION=3.8
84+
- VENV=venv
85+
- MB_PYTHON_OSX_VER=10.9
86+
- MB_ML_VER=2010
8187
- os: osx
8288
env:
8389
- PYTHON_VERSION=pypy-4.0
@@ -143,6 +149,12 @@ matrix:
143149
osx_image: xcode10
144150
env:
145151
- PYTHON_VERSION=3.7
152+
- os: osx
153+
osx_image: xcode10
154+
env:
155+
- PYTHON_VERSION=3.8
156+
- MB_PYTHON_OSX_VER=10.9
157+
- MB_ML_VER=2010
146158
- os: osx
147159
osx_image: xcode10.1
148160
env:

manylinux_utils.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,14 @@ function cpython_path {
1919
#
2020
# For back-compatibility "u" as u_width also means "32"
2121
local py_ver="${1:-2.7}"
22+
local abi_suff=m
2223
local u_width="${2:-${UNICODE_WIDTH}}"
2324
local u_suff=u
25+
# Python 3.8 and up no longer uses the PYMALLOC 'm' suffix
26+
# https://github.com/pypa/wheel/pull/303
27+
if [ $(lex_ver $py_ver) -ge $(lex_ver 3.8) ]; then
28+
abi_suff=""
29+
fi
2430
# Back-compatibility
2531
if [ "$u_width" == "u" ]; then u_width=32; fi
2632
# For Python >= 3.4, "u" suffix not meaningful
@@ -32,7 +38,7 @@ function cpython_path {
3238
exit 1
3339
fi
3440
local no_dots=$(echo $py_ver | tr -d .)
35-
echo "/opt/python/cp${no_dots}-cp${no_dots}m${u_suff}"
41+
echo "/opt/python/cp${no_dots}-cp${no_dots}$abi_suff${u_suff}"
3642
}
3743

3844
function repair_wheelhouse {

osx_utils.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ LATEST_2p7=2.7.16
2121
LATEST_3p5=3.5.4
2222
LATEST_3p6=3.6.8
2323
LATEST_3p7=3.7.4
24+
LATEST_3p8=3.8.0rc1
2425

2526

2627
function check_python {
@@ -83,6 +84,8 @@ function fill_pyver {
8384
echo $LATEST_3p6
8485
elif [ $ver == "3.5" ]; then
8586
echo $LATEST_3p5
87+
elif [ $ver == "3.8" ]; then
88+
echo $LATEST_3p8
8689
else
8790
echo "Can't fill version $ver" 1>&2
8891
exit 1

0 commit comments

Comments
 (0)