fix: address PR feedback for Bedrock Agent parameters with commas

- Change @cached_property to @Property for resolved_query_string_parameters
- Simplify the functional test by directly returning the query parameter
- Remove redundant unit test

Author: matteofigus

aws_lambda_powertools/utilities/data_classes/bedrock_agent_event.py

@@ -112,7 +112,7 @@ def query_string_parameters(self) -> dict[str, str]:
         parameters = self.get("parameters") or []
         return {x["name"]: x["value"] for x in parameters}
 
-    @cached_property
+    @property
     def resolved_query_string_parameters(self) -> dict[str, list[str]]:
         """
         Override the base implementation to prevent splitting parameter values by commas.

aws_lambda_powertools/utilities/data_classes/common.py

@@ -168,7 +168,7 @@ def query_string_parameters(self) -> dict[str, str]:
     def multi_value_query_string_parameters(self) -> dict[str, list[str]]:
         return self.get("multiValueQueryStringParameters") or {}
 
-    @cached_property
+    @property
     def resolved_query_string_parameters(self) -> dict[str, list[str]]:
         """
         This property determines the appropriate query string parameter to be used

tests/functional/event_handler/_pydantic/test_bedrock_agent.py

@@ -348,13 +348,10 @@ def handler() -> Optional[Dict]:
 def test_bedrock_agent_with_comma_parameters():
     # GIVEN a Bedrock Agent resolver
     app = BedrockAgentResolver()
-    received_query = None
 
     @app.post("/sql-query", description="Run a SQL query")
     def run_sql_query(query: Annotated[str, Query()]):
-        nonlocal received_query
-        received_query = query
-        return {"result": "Query executed"}
+        return {"result": query}
 
     # WHEN calling the event handler with a parameter containing commas
     event = {
@@ -384,7 +381,5 @@ def run_sql_query(query: Annotated[str, Query()]):
     result = app(event, {})
 
     # THEN the parameter with commas should be correctly passed to the handler
-    assert received_query == "SELECT a.source_name, b.thing FROM table"
-    assert result["response"]["httpStatusCode"] == 200
     body = json.loads(result["response"]["responseBody"]["application/json"]["body"])
-    assert body["result"] == "Query executed"
+    assert body["result"] == "SELECT a.source_name, b.thing FROM table"

tests/unit/data_classes/required_dependencies/test_bedrock_agent_event.py

@@ -62,35 +62,3 @@ def test_bedrock_agent_event_with_post():
     assert properties[1].name == raw_properties[1]["name"]
     assert properties[1].type == raw_properties[1]["type"]
     assert properties[1].value == raw_properties[1]["value"]
-
-
-def test_bedrock_agent_event_with_comma_parameters():
-    event = {
-        "actionGroup": "TestActionGroup",
-        "messageVersion": "1.0",
-        "sessionId": "12345678912345",
-        "sessionAttributes": {},
-        "promptSessionAttributes": {},
-        "inputText": "Run a SQL query",
-        "agent": {
-            "alias": "TEST",
-            "name": "test",
-            "version": "1",
-            "id": "test123",
-        },
-        "httpMethod": "POST",
-        "apiPath": "/sql-query",
-        "parameters": [
-            {
-                "name": "query",
-                "type": "string",
-                "value": "SELECT a.source_name, b.thing FROM table",
-            },
-        ],
-    }
-
-    parsed_event = BedrockAgentEvent(event)
-
-    assert parsed_event.query_string_parameters["query"] == "SELECT a.source_name, b.thing FROM table"
-    assert parsed_event.resolved_query_string_parameters["query"] == ["SELECT a.source_name, b.thing FROM table"]
-    assert len(parsed_event.resolved_query_string_parameters["query"]) == 1