refactor(NgModel): make sure the required validator uses the $validators pipeline

Author: matsko

src/ng/directive/input.js

@@ -2131,21 +2131,12 @@ var requiredDirective = function() {
       if (!ctrl) return;
       attr.required = true; // force truthy in case we are on non input element
 
-      var validator = function(value) {
-        if (attr.required && ctrl.$isEmpty(value)) {
-          ctrl.$setValidity('required', false);
-          return;
-        } else {
-          ctrl.$setValidity('required', true);
-          return value;
-        }
+      ctrl.$validators.required = function(value) {
+        return !attr.required || !ctrl.$isEmpty(value);
       };
 
-      ctrl.$formatters.push(validator);
-      ctrl.$parsers.unshift(validator);
-
       attr.$observe('required', function() {
-        validator(ctrl.$viewValue);
+        ctrl.$validateLater();
       });
     }
   };

test/ng/directive/inputSpec.js

@@ -2396,7 +2396,7 @@ describe('input', function() {
     it('should be invalid if required and empty', function() {
       compileInput('<input type="text" ng-list ng-model="list" required>');
       changeInputValueTo('');
-      expect(scope.list).toBeUndefined();
+      expect(scope.list).toEqual([]);
       expect(inputElm).toBeInvalid();
       changeInputValueTo('a,b');
       expect(scope.list).toEqual(['a','b']);
@@ -2470,7 +2470,7 @@ describe('input', function() {
     });
 
 
-    it('should be $invalid but $pristine if not touched', function() {
+    it('should be considered $pristine if the value is empty', function() {
       compileInput('<input type="text" ng-model="name" name="alias" required />');
 
       scope.$apply(function() {
@@ -2482,7 +2482,7 @@ describe('input', function() {
 
       changeInputValueTo('');
       expect(inputElm).toBeInvalid();
-      expect(inputElm).toBeDirty();
+      expect(inputElm).toBePristine();
     });