Skip to content

Commit f8c98ec

Browse files
authored
Merge pull request scala#90 from lrytz/module-plugin-2.2
2 parents d0f0504 + 0b23cba commit f8c98ec

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

build.sbt

-9
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,6 @@ lazy val collectionContrib = crossProject(JVMPlatform, JSPlatform)
99
.crossType(CrossType.Pure)
1010
.in(file("."))
1111
.settings(ScalaModulePlugin.scalaModuleSettings)
12-
// as per #71, we are not currently attempting to support OSGi in this repo
13-
.disablePlugins(SbtOsgi)
14-
// disabling the plugin isn't sufficient; we also must refrain from letting sbt-scala-module put
15-
// OSGi stuff in our settings. normally a module build would include the following commented-out
16-
// line. at present (sbt-scala-module 2.1.3), scalaModuleSettingsJVM contains *only* OSGi stuff,
17-
// so the easiest thing is just to omit it. this isn't future-proof; some future sbt-scala-module
18-
// might put additional stuff in scalaModuleSettingsJVM. it would be nice if sbt-scala-module
19-
// provided a setting key to selectively disable OSGi.
20-
// .jvmSettings(ScalaModulePlugin.scalaModuleSettingsJVM)
2112
.settings(
2213
name := "scala-collection-contrib",
2314
scalacOptions ++= Seq("-opt-warnings", "-language:higherKinds", "-deprecation", "-feature", "-Xfatal-warnings"),

project/plugins.sbt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
val scalaJSVersion =
22
Option(System.getenv("SCALAJS_VERSION")).filter(_.nonEmpty).getOrElse("0.6.32")
33

4-
addSbtPlugin("org.scala-lang.modules" % "sbt-scala-module" % "2.1.3")
4+
addSbtPlugin("org.scala-lang.modules" % "sbt-scala-module" % "2.2.0")
55

66
addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "1.0.0")
77
addSbtPlugin("org.scala-js" % "sbt-scalajs" % scalaJSVersion)

0 commit comments

Comments
 (0)