Skip to content

Commit 11a386f

Browse files
author
Mark Kuhn
committed
fix: test not asserting anything
1 parent c9ff702 commit 11a386f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/test/java/software/amazon/cloudwatchlogs/emf/logger/MetricsLoggerTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,8 @@ void whenDefaultDimension_DimensionValue_Empty() throws DimensionSetExceededExce
9393
assertEquals(1, sink.getContext().getDimensions().size());
9494
Set<String> dimensionKeys = sink.getContext().getDimensions().get(0).getDimensionKeys();
9595
assertEquals(2, dimensionKeys.size());
96-
dimensionKeys.contains("ServiceName");
97-
dimensionKeys.contains("ServiceType");
96+
assertTrue(dimensionKeys.contains("ServiceName"));
97+
assertTrue(dimensionKeys.contains("ServiceType"));
9898
}
9999

100100
@Test
@@ -105,8 +105,8 @@ void whenDefaultDimension_DimensionValue_Blank() throws DimensionSetExceededExce
105105
assertEquals(1, sink.getContext().getDimensions().size());
106106
Set<String> dimensionKeys = sink.getContext().getDimensions().get(0).getDimensionKeys();
107107
assertEquals(2, dimensionKeys.size());
108-
dimensionKeys.contains("ServiceName");
109-
dimensionKeys.contains("ServiceType");
108+
assertTrue(dimensionKeys.contains("ServiceName"));
109+
assertTrue(dimensionKeys.contains("ServiceType"));
110110
}
111111

112112
@ParameterizedTest

0 commit comments

Comments
 (0)