Skip to content

Commit ff0f91b

Browse files
committed
servo: Merge #16473 - Upgrade to rustc 1.18.0-nightly (5f13a3b54 2017-04-15) (from servo:rustup); r=emilio
This version enables [struct field reordering][1] which brings the size of the types for specified values of some CSS properties under the threshold such that they shouldn’t be boxed anymore, making unit tests fail. Simply unboxing them moves the test failure to Stylo’s unit tests, since the stable compiler used in that case does not do field re-ordering. Therefore, we manually reorder a couple fields to effectively bring this optimization to older compilers for a few specific types. [1]: rust-lang/rust#40377 Source-Repo: https://github.com/servo/servo Source-Revision: c453e2ef89b32798dabbb23b22cfd5a72dddf6a5 UltraBlame original commit: 55519369af2b2a65f2a5c2275522a8b1dc014953
1 parent 9f759ee commit ff0f91b

File tree

11 files changed

+7
-255
lines changed

11 files changed

+7
-255
lines changed

servo/components/script/dom/element.rs

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5138,11 +5138,6 @@ PropertyDeclaration
51385138
:
51395139
BorderTopWidth
51405140
(
5141-
Box
5142-
:
5143-
:
5144-
new
5145-
(
51465141
width_value
51475142
.
51485143
clone
@@ -5151,7 +5146,6 @@ clone
51515146
)
51525147
)
51535148
)
5154-
)
51555149
;
51565150
hints
51575151
.
@@ -5165,11 +5159,6 @@ PropertyDeclaration
51655159
:
51665160
BorderLeftWidth
51675161
(
5168-
Box
5169-
:
5170-
:
5171-
new
5172-
(
51735162
width_value
51745163
.
51755164
clone
@@ -5178,7 +5167,6 @@ clone
51785167
)
51795168
)
51805169
)
5181-
)
51825170
;
51835171
hints
51845172
.
@@ -5192,11 +5180,6 @@ PropertyDeclaration
51925180
:
51935181
BorderBottomWidth
51945182
(
5195-
Box
5196-
:
5197-
:
5198-
new
5199-
(
52005183
width_value
52015184
.
52025185
clone
@@ -5205,7 +5188,6 @@ clone
52055188
)
52065189
)
52075190
)
5208-
)
52095191
;
52105192
hints
52115193
.
@@ -5219,16 +5201,10 @@ PropertyDeclaration
52195201
:
52205202
BorderRightWidth
52215203
(
5222-
Box
5223-
:
5224-
:
5225-
new
5226-
(
52275204
width_value
52285205
)
52295206
)
52305207
)
5231-
)
52325208
;
52335209
}
52345210
}

servo/components/style/properties/longhand/border.mako.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -401,11 +401,6 @@ side
401401
-
402402
width
403403
"
404-
boxed
405-
=
406-
"
407-
True
408-
"
409404
animation_type
410405
=
411406
"

servo/components/style/properties/longhand/box.mako.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15520,9 +15520,6 @@ extra_prefixes
1552015520
moz
1552115521
webkit
1552215522
"
15523-
boxed
15524-
=
15525-
True
1552615523
creates_stacking_context
1552715524
=
1552815525
True

servo/components/style/properties/longhand/column.mako.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,6 @@ extra_prefixes
8989
"
9090
moz
9191
"
92-
boxed
93-
=
94-
True
9592
animation_type
9693
=
9794
"
@@ -263,9 +260,6 @@ moz
263260
experimental
264261
=
265262
True
266-
boxed
267-
=
268-
True
269263
animation_type
270264
=
271265
"
@@ -397,11 +391,6 @@ products
397391
"
398392
gecko
399393
"
400-
boxed
401-
=
402-
"
403-
True
404-
"
405394
animation_type
406395
=
407396
"

servo/components/style/properties/longhand/inherited_text.mako.rs

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3265,11 +3265,6 @@ letter
32653265
-
32663266
spacing
32673267
"
3268-
boxed
3269-
=
3270-
"
3271-
True
3272-
"
32733268
animation_type
32743269
=
32753270
"
@@ -9089,9 +9084,6 @@ products
90899084
"
90909085
gecko
90919086
"
9092-
boxed
9093-
=
9094-
True
90959087
animation_type
90969088
=
90979089
"
@@ -9313,11 +9305,6 @@ stroke
93139305
-
93149306
width
93159307
"
9316-
boxed
9317-
=
9318-
"
9319-
True
9320-
"
93219308
animation_type
93229309
=
93239310
"

servo/components/style/values/computed/length.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,9 +335,9 @@ Length
335335
:
336336
Calc
337337
(
338+
range
338339
ref
339340
calc
340-
range
341341
)
342342
=
343343
>

servo/components/style/values/specified/length.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2784,11 +2784,11 @@ NoCalcLength
27842784
)
27852785
Calc
27862786
(
2787+
AllowedLengthType
27872788
Box
27882789
<
27892790
CalcLengthOrPercentage
27902791
>
2791-
AllowedLengthType
27922792
)
27932793
}
27942794
impl
@@ -2862,9 +2862,9 @@ Length
28622862
:
28632863
Calc
28642864
(
2865+
_
28652866
ref
28662867
calc
2867-
_
28682868
)
28692869
=
28702870
>
@@ -2934,9 +2934,9 @@ Length
29342934
:
29352935
Calc
29362936
(
2937+
_
29372938
ref
29382939
calc
2939-
_
29402940
)
29412941
=
29422942
>
@@ -5310,14 +5310,14 @@ Length
53105310
:
53115311
Calc
53125312
(
5313+
num_context
53135314
Box
53145315
:
53155316
:
53165317
new
53175318
(
53185319
calc
53195320
)
5320-
num_context
53215321
)
53225322
}
53235323
)
@@ -6950,8 +6950,8 @@ Length
69506950
:
69516951
Calc
69526952
(
6953-
l
69546953
_
6954+
l
69556955
)
69566956
=
69576957
>

servo/ports/geckolib/glue.rs

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -10533,11 +10533,6 @@ into
1053310533
BorderTopWidth
1053410534
=
1053510535
>
10536-
Box
10537-
:
10538-
:
10539-
new
10540-
(
1054110536
BorderWidth
1054210537
:
1054310538
:
@@ -10549,15 +10544,9 @@ into
1054910544
(
1055010545
)
1055110546
)
10552-
)
1055310547
BorderRightWidth
1055410548
=
1055510549
>
10556-
Box
10557-
:
10558-
:
10559-
new
10560-
(
1056110550
BorderWidth
1056210551
:
1056310552
:
@@ -10569,15 +10558,9 @@ into
1056910558
(
1057010559
)
1057110560
)
10572-
)
1057310561
BorderBottomWidth
1057410562
=
1057510563
>
10576-
Box
10577-
:
10578-
:
10579-
new
10580-
(
1058110564
BorderWidth
1058210565
:
1058310566
:
@@ -10589,15 +10572,9 @@ into
1058910572
(
1059010573
)
1059110574
)
10592-
)
1059310575
BorderLeftWidth
1059410576
=
1059510577
>
10596-
Box
10597-
:
10598-
:
10599-
new
10600-
(
1060110578
BorderWidth
1060210579
:
1060310580
:
@@ -10609,7 +10586,6 @@ into
1060910586
(
1061010587
)
1061110588
)
10612-
)
1061310589
MarginTop
1061410590
=
1061510591
>

servo/rust-commit-hash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
474f7a91eec8cba83b7eb7a578a7adb70614f877
1+
5f13a3b540ab6024665322d716e487c800645f24

0 commit comments

Comments
 (0)