Skip to content

Refresh timer not started after page reload #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
uklimaschewski opened this issue Dec 5, 2019 · 2 comments
Closed

Refresh timer not started after page reload #683

uklimaschewski opened this issue Dec 5, 2019 · 2 comments
Labels
bug For tagging faulty or unexpected behavior. investigation-needed Indication that the maintainer or involved community members may need to investigate more.

Comments

@uklimaschewski
Copy link

When using spring boot authentication server with password flow, there is no id token sent from the server. If now the page is reloaded after a successful login, the token refresh timer does not start.
After debugging into the library, the following line in setupRefreshTimer() seems to cause the problem:

if (this.hasValidIdToken()) {

From my understanding, the timer reset & restart should not only be limited to a valid id token present.
Doing a
if (this.hasValidIdToken() || this.hasValidAccessToken()) {
should possibly fix the problem.

@jeroenheijmans jeroenheijmans added bug For tagging faulty or unexpected behavior. investigation-needed Indication that the maintainer or involved community members may need to investigate more. labels Dec 5, 2019
@fletcheri
Copy link

Agree this resolves the issue for me

@manfredsteyer
Copy link
Owner

Will be solved with version 9.

Honestly, I think this is a gray zone: One could argue that not having a valid id_token means your session is expired. Feel free to prove me wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For tagging faulty or unexpected behavior. investigation-needed Indication that the maintainer or involved community members may need to investigate more.
Projects
None yet
Development

No branches or pull requests

4 participants