Skip to content

Consider supporting performing code + PKCE via a popup #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rkara opened this issue Aug 12, 2019 · 0 comments · Fixed by #609
Closed

Consider supporting performing code + PKCE via a popup #602

rkara opened this issue Aug 12, 2019 · 0 comments · Fixed by #609
Labels
feature-request Improvements and additions to the library. pr-welcome We'd welcome a PR to solve the issue.

Comments

@rkara
Copy link

rkara commented Aug 12, 2019

Is your feature request related to a problem? Please describe.
Issue #468 added the ability to perform implicit flow via a popup, it would be beneficial to be able to also perform the code + PKCE authentication via a popup as well.

Describe the solution you'd like
I would like an initLoginFlowInPopup method as well as an initCodeFlowInPopup method added to the OAuthService to align PKCE authentication with implicit flow.
@manfredsteyer manfredsteyer added feature-request Improvements and additions to the library. pr-welcome We'd welcome a PR to solve the issue. labels Aug 12, 2019
@KevinCathcart KevinCathcart mentioned this issue Aug 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request Improvements and additions to the library. pr-welcome We'd welcome a PR to solve the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for code flow silent-refresh and popup KevinCathcart/angular-oauth2-oidc
2 participants
@manfredsteyer @rkara