OAuthResourceServerConfig: customUrlValidation not used when allowedUrls not set

[jhilscher]

Describe the bug

OAuthModule.forRoot({
      resourceServer: {
        sendAccessToken: true,
        customUrlValidation: someValidationFn...
      },
})

1: The customUrlValidation function is not being called unless allowedUrls is definied.
2: When allowedUrls and customUrlValidation are definied, only customUrlValidation is used to verify the urls

To Reproduce
Use the resourceServerConfig from above.

Expected behavior
1: customUrlValidation should be used, even if allowedUrls is null/undefined.
2: if both customUrlValidation and allowedUrls are set, both should be used to validate the url.

Desktop (please complete the following information):

• OS: all
• Browser all
• Version 8.0.2

[manfredsteyer]

Thanks for pointing this out.

So, the quick fix is to set allowedUrls to an empty array even if the customUrlValidation does not need it.

Next version: The proper fix is, to do it as described by you

[adrianbenjuya]

There is a PR #584

[manfredsteyer]

merged the PR. Thanks!