-
Notifications
You must be signed in to change notification settings - Fork 694
Support for authorization code flow #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi There already exit an issue about this topic. #19 I have implemented a solution for supporting authorization code flow. @manfredsteyer, any plans for merging PR's anytime soon? |
+1 |
2 similar comments
+1 |
+1 |
+1 - would be good to get this PR integrated |
Sorry, I don't manage to support such many variation. I will focus on Implicit Flow which is the most suitable one for browser-based SPA. Feel free to fork this library for other flows. |
Hi I think this great library need to include the authorization code flow to be complete, and I think its sad it can’t be part of this package. I personally prefer to use the authorization code flow as I think the silent refresh mechanism of the implicit flow is a dirty hack. I have forked this repository and added support for the authorization code flow. PKCE is currently not implemented. Go check it out at https://www.npmjs.com/package/angular-oauth2-oidc-codeflow (Name, versioning, structure, etc. might change in the future) |
The fact that is the most used does not invalidate that is the more insecure way of doing this. Please have a read on these links, from https://oauth.net/2/grant-types/implicit/
ory hydra is a complete implementation of oauth2 RFC authorization server based on best practices and security focused: |
Hi bechhansen! |
Hi @bechhansen ! |
Hi @RFIhism |
Hi @bechhansen ! |
It should work. I have currently a solution running using it. PKCE is currently not implemented though. |
In my project,I Don't need to use the PKCE when I'm developping a web application with angular 7 and my server run in HTTPs(are secured). please can i take a look to your solution when can help me. Thanks a lot for your interest and your help. |
Sorry, my app is not public so I can not share it. Also I might be about to stop using the library as I'm not happy with my IDP (Amazon Cognito). Have a look at the example at https://github.com/bechhansen/angular-oauth2-oidc. This is pretty much how I use the library. |
Hi @bechhansen ! Thanks for your response. I looked your fork but you still use the implicit flow also! When you are difined it in the file "oauth-service.ts" #1066 |
@RFIhism the implicit flow is still available in the fork, but it is extended with functionality for code flow. |
Because of my application structure, I'm looking to use authorization code flow and pass the code to a backend server which will take over from there.
Does this library have any way to support that? Or ideas of a different one you played with?
Thanks,
B Wins
The text was updated successfully, but these errors were encountered: