Skip to content

Angular 5 #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flexguse opened this issue Nov 15, 2017 · 6 comments
Closed

Angular 5 #162

flexguse opened this issue Nov 15, 2017 · 6 comments

Comments

@flexguse
Copy link

Hi,

I'm pretty new to Angular but I wan't to create a little sample Angular App to check how to connect to our SSO system Keycloak.

I installed the latest Angular cli (Version 1.5), created a project, added your library and followed your readme. Something went wrong, I did not succeed because the OAuthService could not be injected.

A closer look what happens when using
npm i angular-oauth2-oidc --save
said angular-oauth2-oidc version 2.1.8 has some unresolved dependencies.

After that I tried to get your sample up and running, which resulted in this error
You seem to not be depending on "@angular/core". This is an error.

I know you mention in the readme your library is tested successfully with Angular 2 and 4. Unfortunately I have no clue how to downgrade, so are there any plans to get the library running with Angular 5?

Cheers,
Christoph

@flexguse
Copy link
Author

I managed to downgrade to Angular 4 and I was able to use the implicit authentication flow.

Now the question remains if there are any plans to make angular-oauth2-oidc compatible with Angular 5?

@asadsahi
Copy link

asadsahi commented Nov 15, 2017

@flexguse difficult to say without seeing error ,but I am using this with angular 5. The error I had at first was that I stopped using HttpModule. New one is HttpClientModule which angular 5 uses and this library still has reliance on HttpModule. So you need to include HttpModule in angular 5 until oidc library catches up with new http client. I think there is an existing issue as well.

@jraadt
Copy link

jraadt commented Nov 15, 2017

The PR to replace HttpModule with HttpClientModule has been merged in #152. Hopefully @manfredsteyer can publish a new version to NPM soon so everyone can have access to the Angular 5 version.

@flexguse
Copy link
Author

Hi,
thanks for your help! I'll proceed learning Angular with version 4 and I am looking forward having a angular-oauth2-oidc version compatible with Angular 5.

@manfredsteyer
Copy link
Owner

+1 we are on it and Angular 5 support will arrive soon.

@asadsahi
Copy link

can't wait for it... 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants