Skip to content

Compatibilty with older Versions of Angular #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bschnabel opened this issue Aug 5, 2021 · 1 comment
Closed

Compatibilty with older Versions of Angular #1111

bschnabel opened this issue Aug 5, 2021 · 1 comment
Labels
docs Issues that involve improving or adding documentation.

Comments

@bschnabel
Copy link

bschnabel commented Aug 5, 2021

Hello,

The README states the following:

Angular 12: Use 12.x versions of this library (should also work with older Angular versions!).
Angular 11: Use 10.x versions of this library (should also work with older Angular versions!).
Angular 10: Use 10.x versions of this library (should also work with older Angular versions!).
Angular 9: Use 9.x versions of this library (should also work with older Angular versions!).

On the other hand if I try to use Version 12.x with an older Anglar version npm throws:

npm WARN [email protected] requires a peer of @angular/core@>=12.0.0 but none is installed. You must install peer dependencies yourself.

How does this fit together? Is it safe to ignore this warning?

To Reproduce

  1. Generate plain new Angular Projekt with Angular Version 9, 10, or 11
  2. Add "angular-oauth2-oidc": "^12.0.1", as a dependency in package.json
  3. execute npm install
  4. See error

Expected behavior
If the readme states it should work with older Angular Versions, version 12.x should not have peer dependency of @angular/core@>=12.0.0.
So expected behaviour would be no error output from npm

@jeroenheijmans jeroenheijmans added the docs Issues that involve improving or adding documentation. label Aug 5, 2021
@manfredsteyer
Copy link
Owner

Hi,

we only test-lib version 12 with Angular 12 and lib version 11 with Angular 11 etc. However, as breaking changes are quite rare and as this library only uses services, chances are very high that everything works with older versions. We cannot guarantee it but chances are high.

Best wishes,
Manfred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues that involve improving or adding documentation.
Projects
None yet
Development

No branches or pull requests

3 participants