fix: Remove space specific business logic from Python SDK function to fetch execution role (aws#4552)

Co-authored-by: Henry Wang <[email protected]>

Author: 2 people

src/sagemaker/session.py

@@ -5668,7 +5668,6 @@ def get_caller_identity_arn(self):
                 instance_name = metadata.get("ResourceName")
                 domain_id = metadata.get("DomainId")
                 user_profile_name = metadata.get("UserProfileName")
-                space_name = metadata.get("SpaceName")
                 execution_role_arn = metadata.get("ExecutionRoleArn")
             try:
                 if domain_id is None:
@@ -5681,11 +5680,6 @@ def get_caller_identity_arn(self):
                 if execution_role_arn is not None:
                     return execution_role_arn
 
-                # In Shared Space app, find execution role from DefaultSpaceSettings on domain level
-                if space_name is not None:
-                    domain_desc = self.sagemaker_client.describe_domain(DomainId=domain_id)
-                    return domain_desc["DefaultSpaceSettings"]["ExecutionRole"]
-
                 user_profile_desc = self.sagemaker_client.describe_user_profile(
                     DomainId=domain_id, UserProfileName=user_profile_name
                 )

tests/unit/test_session.py

@@ -723,28 +723,6 @@ def test_get_caller_identity_arn_from_metadata_file_for_space(boto_session):
     assert actual == expected_role
 
 
-@patch(
-    "six.moves.builtins.open",
-    mock_open(
-        read_data='{"ResourceName": "SageMakerInstance", '
-        '"DomainId": "d-kbnw5yk6tg8j", '
-        '"SpaceName": "space_name"}'
-    ),
-)
-@patch("os.path.exists", side_effect=mock_exists(NOTEBOOK_METADATA_FILE, True))
-def test_get_caller_identity_arn_from_describe_domain_for_space(boto_session):
-    sess = Session(boto_session)
-    expected_role = "arn:aws:iam::369233609183:role/service-role/SageMakerRole-20171129T072388"
-    sess.sagemaker_client.describe_domain.return_value = {
-        "DefaultSpaceSettings": {"ExecutionRole": expected_role}
-    }
-
-    actual = sess.get_caller_identity_arn()
-
-    assert actual == expected_role
-    sess.sagemaker_client.describe_domain.assert_called_once_with(DomainId="d-kbnw5yk6tg8j")
-
-
 @patch(
     "six.moves.builtins.open",
     mock_open(read_data='{"ResourceName": "SageMakerInstance"}'),