Skip to content

Commit c975fc4

Browse files
gfyoungjreback
authored andcommitted
TST: Check pytables<3.5.1 when skipping (pandas-dev#25773)
* TST: Check pytables<3.5.1 when skipping 3.5.1 was made available on conda, causing 'xfail_non_writeable' tests to fail. * TST: Skip geopandas downstream test xref pandas-devgh-25778
1 parent c8ba766 commit c975fc4

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

pandas/tests/io/test_pytables.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,8 @@
3838
# remove when gh-24839 is fixed; this affects numpy 1.16
3939
# and pytables 3.4.4
4040
xfail_non_writeable = pytest.mark.xfail(
41-
LooseVersion(np.__version__) >= LooseVersion('1.16'),
41+
LooseVersion(np.__version__) >= LooseVersion('1.16') and
42+
LooseVersion(tables.__version__) < LooseVersion('3.5.1'),
4243
reason=('gh-25511, gh-24839. pytables needs a '
4344
'release beyong 3.4.4 to support numpy 1.16x'))
4445

pandas/tests/test_downstream.py

+1
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,7 @@ def test_pandas_datareader():
118118
@pytest.mark.filterwarnings("ignore:The 'warn':DeprecationWarning")
119119
@pytest.mark.filterwarnings("ignore:pandas.util:DeprecationWarning")
120120
@pytest.mark.filterwarnings("ignore:can't resolve:ImportWarning")
121+
@pytest.mark.skip(reason="gh-25778: geopandas stack issue")
121122
def test_geopandas():
122123

123124
geopandas = import_module('geopandas') # noqa

0 commit comments

Comments
 (0)