flipping back to using NaN, awaiting PR code42#245

Author: maddie-vargo

src/code42cli/cmds/devices.py

@@ -1,6 +1,7 @@
 from datetime import date
 
 import click
+import numpy as np
 from pandas import concat
 from pandas import DataFrame
 from pandas import json_normalize
@@ -362,11 +363,11 @@ def _add_legal_hold_membership_to_device_dataframe(sdk, df):
         how="left",
         left_on="userUid",
         right_on="user.userUid",
-    ).fillna(value="")
+    )
 
     df.loc[
         df["status"] == "Deactivated", ["legalHold.legalHoldUid", "legalHold.name"],
-    ] = ""
+    ] = np.nan
 
     return df
 

tests/cmds/test_devices.py

@@ -1,5 +1,6 @@
 from datetime import date
 
+import numpy as np
 import pytest
 from pandas import DataFrame
 from pandas._testing import assert_frame_equal
@@ -679,8 +680,8 @@ def test_list_include_legal_hold_membership_pops_legal_hold_if_device_deactivate
             {
                 "userUid": "840103986007089121",
                 "status": "Deactivated",
-                "legalHold.legalHoldUid": "",
-                "legalHold.name": "",
+                "legalHold.legalHoldUid": np.nan,
+                "legalHold.name": np.nan,
             },
             {
                 "userUid": "840103986007089121",