Skip to content

Commit dae4fab

Browse files
LinusBorgmactanxin
authored andcommitted
fix(e2e-nightwatch): check for correct flag name (vuejs#5016)
* fix(e2e-nightwatch): check for correct flag name flag is documented as `--use-selenium` but we checked for `args['with-selenium']` fix vuejs#5015 * test(e2e-nightwatch): selenium test uses correct flag now
1 parent 7f1912e commit dae4fab

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ describe('nightwatch e2e plugin', () => {
6969
})
7070

7171
test('should run single test with custom nightwatch.json and selenium server', async () => {
72-
await project.run(`vue-cli-service test:e2e --headless --with-selenium -t tests/e2e/specs/test.js`)
72+
await project.run(`vue-cli-service test:e2e --headless --use-selenium -t tests/e2e/specs/test.js`)
7373
let results = await project.read('test_results.json')
7474
results = JSON.parse(results)
7575

packages/@vue/cli-plugin-e2e-nightwatch/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ module.exports = (api, options) => {
6565
rawArgs.push('--env', 'chrome')
6666
}
6767

68-
if (args['with-selenium']) {
68+
if (args['use-selenium']) {
6969
process.env.VUE_NIGHTWATCH_USE_SELENIUM = '1'
7070
}
7171

0 commit comments

Comments
 (0)